From: Pete B. <pb...@gm...> - 2010-12-09 01:32:30
|
On 2010.12.09 00:22, Michael Plante wrote: > Pete Batard wrote: >>> Michael, do you have any reason to expect that the proposed change >>> (-text in gitattributes then adding CRLF files into official) is going >>> to cause issues, like the ones you have seen, on official? > > I have no idea. If you're wondering why you haven't seen a definite answer > from me on that so far, that's why. The only theory I've had so far about > why git was acting up has fallen apart again. OK. If you want to think about it further, and try to figure out the issue git is having, fair enough (I'd like to have some logic behind what git does on CRLF conversions too). But while you do that, and I think you're already well aware of it, please remember that we are trying to analyse 2 different issues here (or one real issue and one potential) and that the July commit was only a corrective commit that was applied so that we could introduce a different one for integration. And for people who are still reading this thread, these 2 different commits can be summarized as follows: July commit: "Shoot:, we should never have left MS project files to be stored as LF in the repo while we want them CRLF, so let's fix that while we're experimental." [1] Proposed (official) commit: "Before we introduce the MS project files, let us make sure they are stored as CRLF in the repo" [2], and then add them [3]. Regards, /Pete PS: Ah, [2]. Can't help but wish this one hadn't fallen through the cracks back then... [1] http://git.libusb.org/?p=libusb-pbatard.git;a=commitdiff;h=b5820d34ad6fd3fa719d861daa58e25789ccf232;js=1 [2] http://marc.info/?l=libusb-devel&m=128103042522279&w=2 (NB: now that I read the mail again, I think I did actually find out that I couldn't open LF'd MSVC6 project files when I tested on VMWare) [3] http://marc.info/?l=libusb-devel&m=128103057922488&w=2 |