Re: [libtorrent] patch: docs/reference-Session.html (dht_put_item)
Brought to you by:
arvidn
From: Angel L. <gub...@gm...> - 2014-10-18 13:35:23
|
Calum, I've already taken that step, and I keep a github git repo in sync here, it'd just be a matter of libtorrent's team, forking it and continuing to work on it. https://github.com/gubatron/libtorrent https://github.com/gubatron/libtorrent/commits/master Certainly a lot more people would come out and help if the collaboration process was more convenient. As for the branching model, we're using I believe that exact same branching model for OpenBazaar, I must say I prefer having a simple master branch and everyone submitting patches on clean feature branches, reviewing throughly and then just merging to master. Once the master branch is in a state good enough to make a release you just tag the master branch at that point in time and github will even make .zip and .tar.gz for non git users to download the release. This simple master/features model is the one used by the linux kernel on github, also for Bitcoin core. Works well and it's simple for contributors that are new to git. http://twitter.com/gubatron On Sat, Oct 18, 2014 at 7:11 AM, Calum Lind <cal...@gm...> wrote: > I have to agree about switching to git, I find using SVN painful and > it is possible that more contributors might appear out of the > woodwork. > > With judicious rebasing and merging of branches you can keep the > commit history clean plus it's usually trivial to merge or cherry-pick > (depends on branch history) changes to other branches. > > I'm not sure if you have seen this but the git workflow > http://nvie.com/posts/a-successful-git-branching-model/ is the > generally approved way to maintain a git repo. > > I also just was that there is an import tool on github that might be > useful in converting SVN to git without the headache? > https://help.github.com/articles/importing-your-project-to-github/ > > On 17 October 2014 20:30, Angel Leon <gub...@gm...> wrote: > > Thank you. > > > > I have hopes then for libtorrent to end up moving ultimately to github > > then. I've never had any issues with github servers with very large > > projects being imported from old version control systems. > > > > If you value clean history and branching, then you will enjoy git/github > > very much, branching couldn't be any easier, and keeping the repository > > history clean is very easy when collaborators are working on feature > > branches, once they're done, annoying cosmetic commits can be squashed > into > > more meaningful ones, when things get merged history remains clean, and > the > > process is simple. > > > > It would bring the collaboration to this project to another level, code > > revisions, issue reporting, and all sorts of integrations are possible > > (code coverage checks, continuous integration testing, so that branches > > can't get merged unless they pass tests) > > > > Cheers > > > > http://twitter.com/gubatron > > > > On Thu, Oct 16, 2014 at 12:41 PM, arvid <ar...@cs...> wrote: > > > >> On 2014-10-16 04:35, Angel Leon wrote: > >> > >>> I think there's an important typo on the mutable > `Session::dht_put_item` > >>> documentation. (the dht_put_item function that takes a key and > signature > >>> is > >>> meant for mutable puts, right?) > >>> > >> > >> thanks. fixed (that document is generated from > include/libtorrent/session. > >> hpp) > >> > >> Is this the way to collaborate with the project? (sending .diff files?) > >>> > >> > >> This is certainly acceptable. > >> > >> It'd be awesome if we could collaborate via git/github. > >>> > >>> A synced repo with all the svn history on github.com is ready for you > >>> guys > >>> to just create an official fork. > >>> > >>> https://github.com/gubatron/libtorrent > >>> > >>> Would be so much better to collaborate and grow this wonderful project. > >>> > >> > >> I'm happy to apply patches whatever form they take. a pull request > against > >> this > >> repo would be fine (assuming it stays up-to-date). I've actually tried > >> several > >> time to migrate/mirror the libtorrent repo in a git repo, without > success > >> (specifically google code, and its server kept failing half-way > through). > >> I value the clean history and branches of subversion though, I'd like to > >> keep the main tree there. > >> > >> -- > >> Arvid Norberg > >> > > > ------------------------------------------------------------------------------ > > Comprehensive Server Monitoring with Site24x7. > > Monitor 10 servers for $9/Month. > > Get alerted through email, SMS, voice calls or mobile push notifications. > > Take corrective actions from your mobile device. > > http://p.sf.net/sfu/Zoho > > _______________________________________________ > > Libtorrent-discuss mailing list > > Lib...@li... > > https://lists.sourceforge.net/lists/listinfo/libtorrent-discuss > > > ------------------------------------------------------------------------------ > Comprehensive Server Monitoring with Site24x7. > Monitor 10 servers for $9/Month. > Get alerted through email, SMS, voice calls or mobile push notifications. > Take corrective actions from your mobile device. > http://p.sf.net/sfu/Zoho > _______________________________________________ > Libtorrent-discuss mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libtorrent-discuss > |