From: Roy S. <roy...@ic...> - 2007-10-18 23:54:16
|
On Fri, 19 Oct 2007, Ondrej Certik wrote: > P.S. In the attached diff, you can skip the "debian/*" dir, that's > debian specific, but the rest are things I had to fix in libmesh, in > order to compile. It looks like your changes to PETSc code are already in libMesh 0.6.1 candidates, except that we've kept the old code around wrapped by #if PETSC_VERSION_LESS_THAN macros. We want compatibility with the latest PETSc, but we didn't want to break compatibility with slightly older PETSc versions to get it. Those lines commented out in the Laspack files don't look like a fix so much as a "compilation workaround which will break other people's code". We try to avoid integrating those into the libMesh trunk, although I admit I've slipped up now and then. ;-) I'm confused as to why you'd need to comment anything out in the first place. If HAVE_LASPACK is disabled then there shouldn't be any Laspack-specific code that gets through the preprocessor. If that's not the case, then we want to wrap the offending code in #ifdef HAVE_LASPACK, not get rid of it entirely. --- Roy |