Re: [Libmesh-devel] Parameters

[Roy S. <roy...@ic...>]

On Wed, 7 Dec 2011, Kirk, Benjamin (JSC-EG311) wrote:

>> Any thoughts on this?  For now I could get away with just making the data
>> members protected but in the long run we could avoid more user problems by
>> making some of the functions virtual.  Do you think libMesh would have any use
>> for some of the functions we have implemented in our version of the class?  I
>> haven't seen any changes in there for the past few years so maybe not.
>
> For a class like this I see no issues with changing from private to
> protected and putting in some virtual functions - it is not like the vtable
> overhead will be critical in this section of code where there are so many
> string comparisons going on.

Agreed.  The Parameters class is already inefficient; making it
infintesimally more inefficient is fine.  ;-)

> As for your improvements, if they can be incorporated in a way that does not
> break the current API I'd welcome them.

Also agreed.
---
Roy