From: Roy S. <ro...@st...> - 2008-08-20 04:52:51
|
On Tue, 19 Aug 2008, Derek Gaston wrote: > Any objections to making new constructors for both LogicError and > NotImplemented that take std::strings.... that way more useful messages > (like _what_ isn't implemented) can be printed? No objections, but I'd like to know more about how these might be used. It seems to me that if the information in the string is just going to std::cerr, we might as well just send the string to cerr without passing it through an exception object first. Otherwise if there's information that a program incorporating the library can use, an arbitrary string probably isn't the best way to encode it. As for finding out what isn't implemented, couldn't we do that automatically by creating a libmesh_not_implemented() macro to use instead of just calling a raw LIBMESH_THROW(NotImplemented())? With a macro we could do the same thing libmesh_error() does and report file, line number, and stack trace information. --- Roy |