Re: [Kile-devel] Review Request 106646: Change LaTeX::updateBibs() to avoid implicit check of the master document

[Eugene S. <eug...@gm...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106646/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 10:40 p.m.)


Review request for Kile and Michel Ludwig.


Changes
-------

Do not use STL. Did not do this intentionally, but, from my point of view, the code became more "knotty". 

Since the final target of these changes was to enhance LaTeX::updateBibs(), I've added required changes to the review. And after doing this it looks like the better way would be to modify Info::lastModifiedFile() and add an option a-la "do not include self". Then LaTeX::updateBibs() would just change one line:

return needsUpdate(targetDir() + '/' + S() + ".bbl", docinfo->lastModifiedFile(dependencies)); into
return needsUpdate(targetDir() + '/' + S() + ".bbl", docinfo->lastModifiedFile(dependencies, checkOnlyBibDependencies));

Then the separate function KileUtilities::lastModifiedFile() becomes good, but not required thing. What do you think?


Repository: kile


Description
-------

Kind of addition to https://git.reviewboard.kde.org/r/106617/

This patch takes part of Info::lastModifiedFile() that works with file list, and splits it into  free function. The last one is called from Info::lastModifiedFile() and from LaTeX::updateBibs().
This allows updateBibs(true) to avoid implicit check of the master document.


Michel, seem like I forgot to add you to reviewers one year ago and you missed this review request. It is exceptional useful for LivePreview. Everytime I see my wife spending twice the time I do in waiting for LivePreview results, I recall this patch :)


Diffs (updated)
-----

  src/documentinfo.cpp 7ea3d6f 
  src/kilestdtools.cpp d68f9a8 
  src/utilities.h afb3af2 
  src/utilities.cpp 9b73e6b 

Diff: http://git.reviewboard.kde.org/r/106646/diff/


Testing
-------


Thanks,

Eugene Shalygin