Re: [Kile-devel] Review Request 109582: Let user define his own quote types

[Michel L. <mic...@gm...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109582/#review29509
-----------------------------------------------------------



src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109582/#comment22011>

    Can you move this to the 'dialogs' folder? or 'dialogs/models'?



src/editorextension.h
<http://git.reviewboard.kde.org/r/109582/#comment22012>

    Can you call this 'predefinedQuotes' instead of 'staticQuotes' everywhere?
    
    Also, can you use two separate lists, one for the predefined ones and one for the user quotes?



src/editorextension.cpp
<http://git.reviewboard.kde.org/r/109582/#comment22014>

    Can you some encode '@' if it occurs in one of the strings? like '\@' (and '\' becomes '\\')



src/editorextension.cpp
<http://git.reviewboard.kde.org/r/109582/#comment22013>

    Actually, why is 'id' needed at all?



src/widgets/latexconfigwidget.cpp
<http://git.reviewboard.kde.org/r/109582/#comment22015>

    Isn't it possible to simply pass the same model (m_quotesModel)to the QuotesConfigDialog?


The path looks good already, there was just one issue when I tried it out - namely, no quote style was selected when I started Kile. Ideally, it would be good to have a mechanism to translate the previous quote style (using numbers) to the new representation in the configuration file.

- Michel Ludwig


On March 19, 2013, 2:02 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109582/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 2:02 p.m.)
> 
> 
> Review request for Kile and Michel Ludwig.
> 
> 
> Description
> -------
> 
> It might have sence to use some other double quotes substitutions in addition to built-in. For instance, in dialogues typesetting. This simple patch adds possibility to add new quote types via configuration dialog.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt b0b03cc 
>   src/dialogs/configurationdialog.cpp cfcf8ff 
>   src/dialogs/quotesconfigdialog.h PRE-CREATION 
>   src/dialogs/quotesconfigdialog.cpp PRE-CREATION 
>   src/dialogs/quotesconfigdialog.ui PRE-CREATION 
>   src/editorextension.h e963129 
>   src/editorextension.cpp fc3906b 
>   src/kile.kcfg cff4670 
>   src/models/quotesmodel.h PRE-CREATION 
>   src/models/quotesmodel.cpp PRE-CREATION 
>   src/widgets/latexconfigwidget.h 57b699d 
>   src/widgets/latexconfigwidget.cpp 6d4a975 
>   src/widgets/latexconfigwidget.ui 502f688 
> 
> Diff: http://git.reviewboard.kde.org/r/109582/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>