#1314 KeePass crashes with System.ArgumentOutOfRangeException when deleting multiple entries at once

[Mertens Bram]

Hi,

While cleaning up some older entries I encountered the following crash.

To reproduce:
1) run KeePass 2.28 on Linux
2) Use search to select several entries
3) press delete to remove several items at once

Result:
[m8ram@formenos ~]$ mono /data/bram/Dropbox/PortableApps/KeePassPortable/KeePass.exe &
[1] 7064
[m8ram@formenos ~]$ System.ArgumentOutOfRangeException: Argument is out of range.
Parameter name: index
at System.Windows.Forms.ListView+ListViewItemCollection.get_Item (Int32 index) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ListView.GetItemAtDisplayIndex (Int32 display_index) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ListView.get_FocusedItem () [0x00000] in <filename unknown="">:0
at (wrapper remoting-invoke-with-check) System.Windows.Forms.ListView:get_FocusedItem ()
at System.Windows.Forms.ListViewItem.get_Focused () [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ListView+ListViewItemCollection.RemoveAt (Int32 index) [0x00000] in <filename unknown="">:0
at KeePass.Forms.MainForm.RemoveEntriesFromList (KeePassLib.PwEntry[] vEntries, Boolean bLockUIUpdate) [0x00000] in <filename unknown="">:0
at KeePass.Forms.MainForm.DeleteSelectedEntries () [0x00000] in <filename unknown="">:0
at KeePass.Forms.MainForm.OnEntryDelete (System.Object sender, System.EventArgs e) [0x00000] in <filename unknown="">:0
at KeePass.Forms.MainForm.OnPwListKeyDown (System.Object sender, System.Windows.Forms.KeyEventArgs e) [0x00000] in <filename unknown="">:0
at (wrapper delegate-invoke) <Module>:invoke_voidthis_object_KeyEventArgs (object,System.Windows.Forms.KeyEventArgs)
at System.Windows.Forms.Control.OnKeyDown (System.Windows.Forms.KeyEventArgs e) [0x00000] in <filename unknown="">:0
at KeePass.UI.CustomListViewEx.OnKeyDown (System.Windows.Forms.KeyEventArgs e) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control.ProcessKeyEventArgs (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control.ProcessKeyMessage (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control.WmKeys (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control.WndProc (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ListView.WndProc (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control+ControlWindowTarget.OnMessage (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control+ControlNativeWindow.WndProc (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.NativeWindow.WndProc (IntPtr hWnd, Msg msg, IntPtr wParam, IntPtr lParam) [0x00000] in <filename unknown="">:0
System.ArgumentOutOfRangeException: Argument is out of range.
Parameter name: index
at System.Windows.Forms.ListView+ListViewItemCollection.get_Item (Int32 index) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ListView.GetItemAtDisplayIndex (Int32 display_index) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ListView.get_FocusedItem () [0x00000] in <filename unknown="">:0
at (wrapper remoting-invoke-with-check) System.Windows.Forms.ListView:get_FocusedItem ()
at System.Windows.Forms.ListViewItem.get_Focused () [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ThemeWin32Classic.DrawListViewItem (System.Drawing.Graphics dc, System.Windows.Forms.ListView control, System.Windows.Forms.ListViewItem item) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ThemeWin32Classic.DrawListViewItems (System.Drawing.Graphics dc, Rectangle clip, System.Windows.Forms.ListView control) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ListView+ItemControl.OnPaintInternal (System.Windows.Forms.PaintEventArgs pe) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control.WmPaint (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control.WndProc (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.ListView+ItemControl.WndProc (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control+ControlWindowTarget.OnMessage (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.Control+ControlNativeWindow.WndProc (System.Windows.Forms.Message& m) [0x00000] in <filename unknown="">:0
at System.Windows.Forms.NativeWindow.WndProc (IntPtr hWnd, Msg msg, IntPtr wParam, IntPtr lParam) [0x00000] in <filename unknown="">:0

[1]+ Exit 1 mono /data/bram/Dropbox/PortableApps/KeePassPortable/KeePass.exe

Regards

Bram

[Paul]

I can't reproduce this in Windows so it is likely to be a mono issue.

cheers, Paul

[Dominik Reichl]

I cannot reproduce this with KeePass 2.28 on Kubuntu 14.10 / Mono 3.2.8. Maybe it was a bug in Mono that already has been fixed. I didn't find any problems in the KeePass code topmost in the stack trace.

Best regards,
Dominik