Re: [Kdenlive-devel] parameters in effects descriptions

[Till T. <ro...@tt...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/07/2011 06:22 AM, Alexandre Prokoudine wrote:
> Hi,
> 
> Is it possible to make parameters n XML descriptions of effects
> translatable? It's most vexing to have all labels in e.g. frei0r RGB
> color adjustment translated, but then see combobox items in English.
> 
Hi,
thanks for adding all the effect files for the sake of localizing.
I just noticed you did some mistakes with blacklisting some effects.
A few frei0r effects are blacklisted likes this:
frei0r_name.xml
although it has to be
frei0r.name

After changing this you will probably notice that they do not work
properly anymore. This is because you did not consider the ranges of the
parameters.
According to the frei0r specs all double parameters have to be in the
range 0-1.
You can fix this issue by adding the factor attribute to the parameters.
For example if max="1000" add factor="1000". But be aware that not every
effect obeys to the specs.

Otherwise good work.


Btw. we should also consider dropping some duplicate effects. I will
maybe have a look at this one soon.

regards Till
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0yG1MACgkQzwEyz7QP6nR12gCeLQFCVWhA8nHp5t4hCMA2EAyv
4i0An1F1/694GSjNTAU31lTCSCqDGZIB
=0By2
-----END PGP SIGNATURE-----