[Jfreechart-commit] jfreechart/source/org/jfree/data/jdbc JDBCCategoryDataset.java,1.4.2.1,1.4.2.2

[David G. <mu...@us...>]

Update of /cvsroot/jfreechart/jfreechart/source/org/jfree/data/jdbc
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8054/source/org/jfree/data/jdbc

Modified Files:
      Tag: STABLE_1-0-0
	JDBCCategoryDataset.java 
Log Message:
2006-03-08  David Gilbert  <dav...@ob...>

	* source/org/jfree/data/jdbc/JDBCCategoryDataset.java
	(executeQuery(Connection, String)): Fixed update loop (bug 1445748).



Index: JDBCCategoryDataset.java
===================================================================
RCS file: /cvsroot/jfreechart/jfreechart/source/org/jfree/data/jdbc/JDBCCategoryDataset.java,v
retrieving revision 1.4.2.1
retrieving revision 1.4.2.2
diff -C2 -d -r1.4.2.1 -r1.4.2.2
*** JDBCCategoryDataset.java	25 Oct 2005 21:33:52 -0000	1.4.2.1
--- JDBCCategoryDataset.java	8 Mar 2006 16:17:46 -0000	1.4.2.2
***************
*** 3,7 ****
   * ===========================================================
   *
!  * (C) Copyright 2000-2005, by Object Refinery Limited and Contributors.
   *
   * Project Info:  http://www.jfree.org/jfreechart/index.html
--- 3,7 ----
   * ===========================================================
   *
!  * (C) Copyright 2000-2006, by Object Refinery Limited and Contributors.
   *
   * Project Info:  http://www.jfree.org/jfreechart/index.html
***************
*** 28,32 ****
   * JDBCCategoryDataset.java
   * ------------------------
!  * (C) Copyright 2002-2005, by Bryan Scott and Contributors.
   *
   * Original Author:  Bryan Scott; Andy;
--- 28,32 ----
   * JDBCCategoryDataset.java
   * ------------------------
!  * (C) Copyright 2002-2006, by Bryan Scott and Contributors.
   *
   * Original Author:  Bryan Scott; Andy;
***************
*** 56,60 ****
   *               executed (TM);
   * 04-Dec-2003 : Added missing Javadocs (DG);
!  *
   */
  
--- 56,63 ----
   *               executed (TM);
   * 04-Dec-2003 : Added missing Javadocs (DG);
!  * ------------- JFREECHART 1.0.0 ---------------------------------------------
!  * 08-Mar-2006 : Fixed bug 1445748 where an exception is thrown if 
!  *               executeQuery() is called more than once (DG);
!  * 
   */
  
***************
*** 75,85 ****
  /**
   * A {@link CategoryDataset} implementation over a database JDBC result set.
!  * The dataset is populated via a call to executeQuery with the string sql
!  * query.
!  * The sql query must return at least two columns.  The first column will be
!  * the category name and remaining columns values.
!  * executeQuery can be called a number of times.
   * <p>
   * The database connection is read-only and no write back facility exists.
   */
  public class JDBCCategoryDataset extends DefaultCategoryDataset {
--- 78,93 ----
  /**
   * A {@link CategoryDataset} implementation over a database JDBC result set.
!  * The dataset is populated via a call to {@link #executeQuery(String)} with 
!  * the string SQL query.  The SQL query must return at least two columns.  The 
!  * first column will be the category name and remaining columns values (each
!  * column represents a series).  Subsequent calls to 
!  * {@link #executeQuery(String)} will refresh the dataset.
   * <p>
   * The database connection is read-only and no write back facility exists.
+  * <p>
+  * NOTE: Many people have found this class too restrictive in general use.  
+  * For the greatest flexibility, please consider writing your own code to read 
+  * data from a <code>ResultSet</code> and populate a 
+  * {@link DefaultCategoryDataset} directly.
   */
  public class JDBCCategoryDataset extends DefaultCategoryDataset {
***************
*** 213,217 ****
              // Remove any previous old data
              int i = getRowCount();
!             for (; i > 0; --i) {
                  removeRow(i);
              }
--- 221,225 ----
              // Remove any previous old data
              int i = getRowCount();
!             while (--i >= 0) {
                  removeRow(i);
              }