jEdit / Plugin Patches / #149 Outline Plugin : The result of parsing is wrong.

#149 Outline Plugin : The result of parsing is wrong.

Status: closed-works-for-me

Owner: Alan Ezust

Labels: None

Priority: 5

Updated: 2012-11-04

Created: 2012-11-03

Creator: funa take

Private: No

Text File
test
test2
test3
test4
test5

Result of parsing (wrong)
root
|-test
|-test2
|-test4

The expected result
root
|-test
| |-test2
|
|-test4

Discussion

Alan Ezust - 2012-11-03

Please attach a test file as an attachment...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

funa take - 2012-11-03

spaces were removed, so I use '_' instead of space.

Text File
test
__test2
____test3
test4
__test5

Result of parsing (wrong)
root
__|-test
______|-test2
______|-test4

The expected result
root
__|-test
__|___|-test2
__|
__|-test4

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

funa take - 2012-11-03

patch.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-03

:folding=indent:
should be at the top of the test.txt file, i believe

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

funa take - 2012-11-03

Sample Text

test.txt

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

funa take - 2012-11-03

:folding=indent: is needed
test.txt file was corrected.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-03

assigned_to: nobody --> shlomy
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-03

Not sure what version your patch was created in, but I tried to apply and i get this:
patch -p0 < patch.diff
(Stripping trailing CRs from patch.)
patching file outline/OutlineAsset.java
Hunk #1 FAILED at 13.
1 out of 1 hunk FAILED -- saving rejects to file outline/OutlineAsset.java.rej
(Stripping trailing CRs from patch.)
patching file outline/OutlineParser.java
Hunk #1 FAILED at 39.
Hunk #2 FAILED at 60.
2 out of 2 hunks FAILED -- saving rejects to file outline/OutlineParser.java.rej

please check your patch against outline's svn trunk?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-03

It appears shlomy made some recent changes to Outline which were never officially released. Assigning to him.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-03

assigned_to: shlomy --> ezust

status: open --> pending-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-03

Hm! it appears that outline trunk already shows me the expected result. Just tested it with your test file.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-03

Please confirm that trunk is good, and i can make release request.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

funa take - 2012-11-04

Sorry, I was looking at old source.
The source code of trunk is good.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-04

status: pending-works-for-me --> closed-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alan Ezust - 2012-11-04

Tagged Outline 1.2.4 for release.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.