#1637 SVN diff always create a svndiff other than a jdiff

closed-fixed
Dale Anson
None
5
2012-09-04
2012-08-09
WuJiayi
No

1. In the projectviewer dockable, select a file then click diff in the subversion menu, svn diff will create a jdiff.
2. Then select a folder in projectviewer and then do svn diff, it will create a svn diff.
3. After select a file again and do svn diff, it will still create a svn diff, in which case i expected it to create a jdiff.
I did some track and found that at step 3 the pv node is considered as a folder.
In all these step i did not check create svn diff in the svn diff dialog.

Discussion

  • WuJiayi
    WuJiayi
    2012-08-31

    I did some more test and seems this only happened with mydoggy dockables.

     
  • Dale Anson
    Dale Anson
    2012-08-31

    • assigned_to: nobody --> daleanson
     
  • Dale Anson
    Dale Anson
    2012-09-04

    Fixed in revision 22162. The diff action from pv was not properly reflecting whether the selected node in pv was a file or directory. Once a directory was selected, files selected after that would be treated as directories. Now the file/directory status is checked properly before doing the diff.

     
  • Dale Anson
    Dale Anson
    2012-09-04

    • status: open --> closed-fixed