#478 Fix bug 3598661

closed-accepted
Thomas Meyer
None
5
2013-04-23
2012-12-28
Thomas Meyer
No

Don't allow negative values in the general option pane.

Discussion

1 2 > >> (Page 1 of 2)
  • Alan Ezust
    Alan Ezust
    2013-01-05

    This UI consistent with the other numeric input field on that page, so it is accepted. You can commit directly.
    The try/catch should be unnecessary though, since the numeric input field restricts input.
    but I wonder why people aren't using an editable spinbox instead for numeric inputs - then you can set a min and a max value for it and you don't have to check for invalid input at all.

     
  • Alan Ezust
    Alan Ezust
    2013-01-05

    • assigned_to: nobody --> thomasmey
    • status: open --> open-accepted
     
  • Thomas Meyer
    Thomas Meyer
    2013-03-16

    New version of the patch attached. This one uses JSpinner component for the number values. Please check the min and max values. are 0 and Integer.MAX sane values for both elements?

     
  • Alan Ezust
    Alan Ezust
    2013-04-15

    This patch depends on java7. Which might be ok, I just want to confirm that we are officially requiring java7 in jEdit 5.1.

     
  • Alan Ezust
    Alan Ezust
    2013-04-17

    • status: open-accepted --> open-remind
     
  • Alan Ezust
    Alan Ezust
    2013-04-17

    please update your patch to work against java 1.6.

     
  • Alan Ezust
    Alan Ezust
    2013-04-17

    Ignore previous comment. Testing your patch now, I see that when the user hits enter, it is not actually consumed by this spinbox and instead registers as an "ok" in the option dialog. There was a similar issue with all comboboxes which was fixed. I will investigate how to fix it for these spinboxes too.

     
1 2 > >> (Page 1 of 2)