[Iperf-users] PATCH: iperf server quits after tcp dual-test

[L. G. S. <so...@cm...>]

In server mode (tcp only), iperf 2.0.4 will quit if a client connects
to it with the -d flag specified:

https://sourceforge.net/tracker/index.php?func=detail&aid=1983829&group_id=128336&atid=711371

The enclosed patch fixes that behavior, but my question, not being
familiar with the code, is why Client::RunTCP() is only intended for
use if threads are available ? Client::Run() will be more than happy
to handle a tcp test if threads aren't used (and even if threads *are*
used, with my patch). Can anyone shed some light on this, and also on
what are we'd be missing by *not* calling RunTCP() from Run() ?

Thanks,
--Gabriel


diff -NarU5 iperf-2.0.4.orig/src/Client.cpp iperf-2.0.4/src/Client.cpp
--- iperf-2.0.4.orig/src/Client.cpp	2008-04-07 22:37:54.000000000 -0400
+++ iperf-2.0.4/src/Client.cpp	2009-01-21 14:10:33.000000000 -0500
@@ -205,14 +205,14 @@
     int adjust = 0; 
 
     char* readAt = mBuf;
 
 #if HAVE_THREAD
-    if ( !isUDP( mSettings ) ) {
-	RunTCP();
-	return;
-    }
+//    if ( !isUDP( mSettings ) ) {
+//	RunTCP();
+//	return;
+//    }
 #endif
     
     // Indicates if the stream is readable 
     bool canRead = true, mMode_Time = isModeTime( mSettings );