Re: [IPCop-devel] [ ipcop-Bugs-2176286 ] Proxy access.log permissions on flash installs

[David W S. <avi...@ai...>]

Eric Oberlander wrote:
> On Sat, Oct 18, 2008 at 9:30 AM, SourceForge.net
> <no...@so...>  wrote:
>> Bugs item #2176286, was opened at 2008-10-18 01:30
>> Message generated for change (Tracker Item Submitted) made by Item Submitter
>> You can respond by visiting:
>> https://sourceforge.net/tracker/?func=detail&atid=428516&aid=2176286&group_id=40604
>>
>> Please note that this message will contain a full copy of the comment thread,
>> including the initial issue submission, for this request,
>> not just the latest update.
>> Category: Web Proxy
>> Group: 1.4.21
>> Status: Open
>> Resolution: None
>> Priority: 5
>> Private: No
>> Submitted By: David W Studeman (Davesworld) (davews)
>> Assigned to: Nobody/Anonymous (nobody)
>> Summary: Proxy access.log permissions on flash installs
>>
>> Initial Comment:
>> When creating a flash image with the latest mkflash script, /var/log/squid/access.log does not exist upon booting a new flash image and is not created by the touch command in rc.flash.up. It is created when one activates the proxy log in the web gui and the resultant mode is 640 not 644. Since the file is one of the files that get compressed with rc.flash.down and if it exists there already, it is left intact with the same mode it was saved in. This patch in the mkflash script completely solves the problem and upon first boot, the access.log file exists properly as mode 644 squid:squid so if the proxy is activated and log enabled, it is readily readable by the web gui with no manual intervention.
>>
>> Also note as per Eric Oberlander, prior to this solution, by deleting the /var/log/squid directory and rebooting, the proper file and mode are there, in the absense of this directory, rc.flash.up will touch properly since sysinit runs with a umask of 022. The changes to mkflash in the below preclude the need to do any of this.
>>
>> Dave Studeman
>
> Hi David
>
> To clarify something that's bugging me, I think you said in the
> previous thread that the 1.9,3 mkflash script works OK, but the 1,4,X
> version does not.
>
> I don't see a huge difference between the two scripts, so why do we
> need to patch one and not the other?
>
> Eric
>

  Your change that you committed to 1.9.3 is definitely the right one 
and does not harm the existing access.log in any way. I think what threw 
me off about the rc.flash.up scripts in both IPCop generations is that 
it would skip over /var/log/squid if the directory is there and not 
touch the access.log. Moving it outside the "if" loop makes it work 
every time.

Hopefully, your changes will make it to 1.4.22 as well. Thanks Eric!

-- 
Dave Studeman
http://www.raqcop.com