From: <no...@so...> - 2007-06-03 18:45:19
|
Update of /cvsroot/ijbswa/current In directory sc8-pr-cvs2.sourceforge.net:/tmp/cvs-serv4778 Modified Files: jcc.c Log Message: Temporary workaround for BR#1730105. Index: jcc.c =================================================================== RCS file: /cvsroot/ijbswa/current/jcc.c,v retrieving revision 1.137 retrieving revision 1.138 diff -u -d -r1.137 -r1.138 --- jcc.c 1 Jun 2007 18:16:36 -0000 1.137 +++ jcc.c 3 Jun 2007 18:45:18 -0000 1.138 @@ -33,6 +33,9 @@ * * Revisions : * $Log$ + * Revision 1.138 2007/06/03 18:45:18 fabiankeil + * Temporary workaround for BR#1730105. + * * Revision 1.137 2007/06/01 18:16:36 fabiankeil * Use the same mutex for gethostbyname() and gethostbyaddr() to prevent * deadlocks and crashes on OpenBSD and possibly other OS with neither @@ -1742,11 +1745,29 @@ if (len <= 0) break; /* error! */ +#if 0 + /* + * XXX: Temporary disabled to prevent problems + * with POST requests whose bodies are allowed to + * contain NULL bytes. BR#1730105. + * + * The main purpose of this check is to properly + * log stuff like BitTorrent traffic and other junk + * that hits public proxies. It's not required for + * Privoxy to functions as those requests are discarded + * later on anyway. + * + * It probably should be rewritten to only check + * the head of the request. Another option would + * be to let all POST requests pass, although that + * may not be good enough. + */ if (request_contains_null_bytes(csp, buf, len)) { /* NULL bytes found and dealt with, just hang up. */ return; } +#endif /* * If there is no memory left for buffering the |