Menu
▾
▴
Re: [privoxy-users] not as valid as it could be
|
From: Andreas O. <oe...@oe...> - 2003-05-12 12:37:44
|
Edward, Dan,
On Sun, 11 May 2003, Edward Rayl wrote:
> Dan Jacobson wrote:
>
> >Gentlemen, I hereby report a bug in that your stuff is not as valid as
> >it could be. Please pass it on the bug staff.
> >
> >*** Errors validating a.html: ***
> >Line 22, character 25: required attribute "TYPE" not specified
> > V<----error below the V
> > text="#000000"><script><!--
The validator is of course right -- script tags should have a type
attribute. OTOH, including one would be a bad idea, since the
required quoting of the value would inevitably break web pages where
<body> is part of a quoted string using the same delimiters.
Including the attribute but omitting the delimiters is pointless,
since that's also invalid HTML and browsers don't need the whole
attribute anyway.
The more elegant solution which we use in other filters, which is
to use the original tag's quoting style, doesn't work here because
<body> doesn't need (ond often doesn't have) attributes to take the
sample from.
Base line: I think it's better to be a little sloppy on HTML but
cautious not to break JavaScript here than the other way round.
Note that the job in question has, since 3.0.2 was released, been
further simplified into
s+<body.*>+$0<script>function PrivoxyWindowOpen(){return(null);}</script>+isU
in order to make it more JavaScipt syntax neutral.
> It may not have made a difference before in the old ugly HTML days, but
> it does now with XHTML. PLEASE don't write code to an XHTML file that
> does not comply with its DTD and causes validation errors. And while
> you are at it, it never hurts to do the same for HTML.
You can to tune the filters for stricter syntax adherence, but be aware
that it often comes at a price. The current default.filter file still has
some rough edges, but generally reflects what I think is the best tradeoff
between formal correctness, real-world usability and cpu-modesty. I'll
happily throw away my filters in favor of better ones anytime, so feel
free to post proposals!
Regards,
--Andreas
|