Menu

#1531 user as password in XMLHttpRequest credentials

Latest SVN
closed
RBRi
None
1
2013-08-01
2013-08-01
No

Hello,

In com.gargoylesoftware.htmlunit.javascript.host.xml.XMLHttpRequest, method open, the password in the request credentials is set to the username:

            if (Undefined.instance != password) {
                passwordCred = user.toString();
            }

Discussion

  • RBRi

    RBRi - 2013-08-01
    • status: open --> accepted
    • assigned_to: RBRi
     
  • RBRi

    RBRi - 2013-08-01

    Upps, you are right.

    Will fix this today in the evening when i have access to the code.
    Thanks for finding.

    It will help if you can create a unit test for this.

     
  • Sebastian Cato

    Sebastian Cato - 2013-08-01

    It will help if you can create a unit test for this.

    Sure thing. Need to set up and familiarize myself a bit first, so it might take a day or so.

     

    Last edit: Sebastian Cato 2013-08-01
  • Sebastian Cato

    Sebastian Cato - 2013-08-01

    Patch with fix and test case attached. If it's too badly written I can give it another shot, given a few pointers in the right direction.

     
  • RBRi

    RBRi - 2013-08-01

    Sebastion,

    thanks for your patch, it was a great help (and time saver) for me.
    Your patch is now (sightly modified) in SVN, the build machine is working...

    Thanks a lot for your support.

    RBRi
    
     
  • RBRi

    RBRi - 2013-08-01
    • status: accepted --> closed
     

Log in to post a comment.