Menu
▾
▴
[gphoto-bugs] [ gphoto-Bugs-3367928 ] libgphoto2-2.4.11 has automagic dependency on jpeg
|
From: SourceForge.net <no...@so...> - 2011-07-17 20:53:08
|
Bugs item #3367928, was opened at 2011-07-15 12:39 Message generated for change (Comment added) made by marcusmeissner You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108874&aid=3367928&group_id=8874 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: build system Group: None Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Pacho Ramos (pacho2) Assigned to: Marcus Meissner (marcusmeissner) Summary: libgphoto2-2.4.11 has automagic dependency on jpeg Initial Comment: As reported downstream at: https://bugs.gentoo.org/show_bug.cgi?id=374371 libgphoto2 will depend on jpeg for some modules automagically when jpeg is found (you can see the reasons why we don't want automagic dependencies in http://www.gentoo.org/proj/en/qa/automagic.xml) I have tried to solve this with this patch, but it fails to solve it, then, would be nice if you could help me with this issue. Thanks The patch: --- configure.ac.old 2011-07-13 16:04:23.000000000 +0200 +++ configure.ac 2011-07-13 16:06:36.000000000 +0200 @@ -259,13 +259,17 @@ LIBJPEG="" libjpeg_msg="no" AC_SUBST(LIBJPEG) -AC_CHECK_LIB(jpeg,jpeg_start_decompress,[ - AC_CHECK_HEADER(jpeglib.h,[ - AC_DEFINE(HAVE_LIBJPEG,1,[define if we found LIBJPEG and its headers]) - LIBJPEG="-ljpeg" - libjpeg_msg="yes" +AC_ARG_WITH([jpeg], AS_HELP_STRING([--without-jpeg], [Build without jpeg library (default: no)])) +AS_IF([test "x$with_jpeg" != "xno"], [ + AC_CHECK_LIB(jpeg,jpeg_start_decompress,[ + AC_CHECK_HEADER(jpeglib.h,[ + AC_DEFINE(HAVE_LIBJPEG,1,[define if we found LIBJPEG and its headers]) + LIBJPEG="-ljpeg" + libjpeg_msg="yes" + ]) ]) ]) + GP_CONFIG_MSG([JPEG mangling support],[${libjpeg_msg}]) dnl --------------------------------------------------------------------------- ---------------------------------------------------------------------- >Comment By: Marcus Meissner (marcusmeissner) Date: 2011-07-17 20:53 Message: yes. ---------------------------------------------------------------------- Comment By: Pacho Ramos (pacho2) Date: 2011-07-17 13:07 Message: Thanks a lot :D I guess we will need to disable both (jpeg and gd) suppports to disable jpeg dependency completely, no? ---------------------------------------------------------------------- Comment By: Marcus Meissner (marcusmeissner) Date: 2011-07-16 17:25 Message: its actually pulled indirectly via libGD. I also made this optional in both trees. (--without-gd) ---------------------------------------------------------------------- Comment By: Marcus Meissner (marcusmeissner) Date: 2011-07-16 17:18 Message: there is perhaps indirect dependency via libexif. let me check ---------------------------------------------------------------------- Comment By: Pacho Ramos (pacho2) Date: 2011-07-16 16:37 Message: But did it worked as expected for you? The problem is that, as I comment in original report, I tried to fix it with this patch but finally I saw that it was still linking to jpeg if it was present in the system :S, and I didn't know how to solve it :( ---------------------------------------------------------------------- Comment By: Marcus Meissner (marcusmeissner) Date: 2011-07-16 11:42 Message: applied to trunk and 2.4 branch, thanks! ---------------------------------------------------------------------- Comment By: Marcus Meissner (marcusmeissner) Date: 2011-07-16 11:29 Message: looks sensible ... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=108874&aid=3367928&group_id=8874 |