Re: [gphoto-devel] Fix crash in libphoto2_port usb module

[Daniel D. <ds...@ge...>]

Marcus Meissner wrote:
> Actually the bug is in libusb-compat, since it is not compatible. I have
> added some checks there for Novell already.

but libusb-0.1 *will* also return NULL from usb_open() in some 
circumstances -- admittedly different circumstances, my point was simply 
that this was already a bug in the code which we just happened to 
unintentionally expose. It's a requirement to check the return value 
from usb_open().

Unfortunately it's not simple to make libusb-compat-0.1 behave the same 
broken way as libusb-0.1 here... libusb-0.1 was a bit silly IMO to let 
you open a device where every single followup call would fail. This is 
documented in the libusb-compat-0.1 README.

Thanks for applying the patch!

As for your libusb-compat-0.1 patch, I took a look at it but it actually 
adds checks where libusb-0.1 had no such thing. If you have time to 
match the behaviour more carefully I would happily apply it.

Thanks,
Daniel