From: Petr M. <mi...@ph...> - 2009-04-09 13:04:21
|
The following two examples: 1. set datafile binary filetype=gpbin plot 'binary3' binary with image 2. set datafile binary filetype=auto plot 'binary3' binary with image stopped working after this patch: 2008-12-02 Ethan Merritt * src/datafile.c (plot_option_binary plot_option_array): Setting default suboptions for binary file input was documented, but never implemented. Now it is. Example 1 works OK in gnuplot 4.2. Example 2 worked in gnuplot 4.3 till 2.12.2008. Now it does not work in gnuplot 4.2 nor in new 4.3. However, it is unclear what format gnuplot expects when there is no format determined from file's extension. There are warnings: plot 'binary3' binary with image warning: Unrecognized filetype; try "show datafile binary filetypes" warning: using default binary record/array structure But what is it "default binary record structure"? I think the default filetype should be "gnuplot binary" (compatibility reasons). --- PM |
From: Ethan M. <merritt@u.washington.edu> - 2009-04-11 02:27:05
|
On Thursday 09 April 2009, Petr Mikulik wrote: > The following two examples: > 1. > set datafile binary filetype=gpbin > plot 'binary3' binary with image > 2. > set datafile binary filetype=auto > plot 'binary3' binary with image > > stopped working after this patch: > > 2008-12-02 Ethan Merritt > > * src/datafile.c (plot_option_binary plot_option_array): > Setting default suboptions for binary file input was documented, but > never implemented. Now it is. I am confused. As the commit comment indicates, prior to that patch the command "set datafile binary filetype=XXX" was a no-op. It did nothing. So if the command sequence worked before that, it did so by coincidence. > Example 1 works OK in gnuplot 4.2. > Example 2 worked in gnuplot 4.3 till 2.12.2008. > Now it does not work in gnuplot 4.2 nor in new 4.3. However, it is > unclear what format gnuplot expects when there is no format determined > from file's extension. Exactly. What is the format of this file? > There are warnings: > plot 'binary3' binary with image > warning: Unrecognized filetype; try "show datafile binary > filetypes" ummmm. Actually, for me that command works fine in current cvs. It only fails if I first issue a "set datafile binary filetype=foo" command. That is consistent with the "set datafile binary filetype=foo" command being a no-op prior to the patch you point to. > warning: using default binary record/array structure > But what is it "default binary record structure"? > I think the default filetype should be "gnuplot binary" (compatibility > reasons). Fine with me. But what exactly is the "gnuplot binary" filetype, and how does one specify or recognize it? -- Ethan Merritt (on the road) |
From: Ethan M. <merritt@u.washington.edu> - 2009-04-11 04:10:36
|
On Thursday 09 April 2009, Petr Mikulik wrote: > The following two examples: > 1. > set datafile binary filetype=gpbin > plot 'binary3' binary with image > 2. > set datafile binary filetype=auto > plot 'binary3' binary with image > > stopped working after this patch: > > 2008-12-02 Ethan Merritt > > * src/datafile.c (plot_option_binary plot_option_array): > Setting default suboptions for binary file input was documented, but > never implemented. Now it is. > > Example 1 works OK in gnuplot 4.2. > Example 2 worked in gnuplot 4.3 till 2.12.2008. > Now it does not work in gnuplot 4.2 nor in new 4.3. The problem appears to be the following line, which is shown commented out. I do not know why it was written that way, and I do not know what other effects may result from removing it. gnuplot/src/datafile.c 2009-04-07 22:06:10.000000000 -0700 @@ -3229,7 +3229,8 @@ plot_option_binary(TBOOLEAN set_matrix, if (!set_default && !set_matrix && df_num_bin_records_default) { int_warn(NO_CARET, "using default binary record/array structure"); // EAM - this seems cause problems. Why is it here? // df_matrix_file = FALSE; } -- Ethan Merritt (on the road) |