From: Mark G. <mg...@us...> - 2003-04-29 20:11:16
|
Update of /cvsroot/gmod/apollo/src/java/apollo/gui In directory sc8-pr-cvs1:/tmp/cvs-serv7884/src/java/apollo/gui Modified Files: DetailInfo.java Log Message: Encoded the Transcript kludge in DetailInfo.getPropertyType in FlyNameAdapter.getBioTypeForDisplay. I think name displaying issues belong in the name adapters, where a programmer can encode their own name preferences for their organism. So FeatureEditPanel now uses NameAdapter.getBioTypeForDisplay to get the type for its lower panel. In following the rules that seemed to be in place, if its a transcript of something other than a gene, than use the parents biotype. I tacked on "transcript" at the end, which seemed appropriate. Nomi feel free to adjust this to your liking. Hope this makes the types issue easier. Why I feel it belongs in the name adapter is that it seemed like display wanted it one with gene transcripts and another way with all other transcripts. This didnt seem like a general naming scheme to me, but something that was appropriate for a name adapter. Index: DetailInfo.java =================================================================== RCS file: /cvsroot/gmod/apollo/src/java/apollo/gui/DetailInfo.java,v retrieving revision 1.22 retrieving revision 1.23 diff -C2 -d -r1.22 -r1.23 *** DetailInfo.java 23 Apr 2003 00:35:26 -0000 1.22 --- DetailInfo.java 29 Apr 2003 20:10:43 -0000 1.23 *************** *** 365,370 **** Config.getPropertyScheme().getFeatureProperty(feature.getType()); String type = property.getDisplayType(); ! if (type.equalsIgnoreCase("gene") && feature instanceof Transcript) // kludge ! return "Transcript"; else return type; --- 365,372 ---- Config.getPropertyScheme().getFeatureProperty(feature.getType()); String type = property.getDisplayType(); ! // But transcripts are in the gene visual type. ! // FlyNameAdapter.getBioTypeForDisplay now deals with this issue ! //if (type.equalsIgnoreCase("gene") && feature instanceof Transcript) // kludge ! //return "Transcript"; else return type; |