Re: [Geotools-devel] Issues from IRC

[Artur H. <ko...@pl...>]

> Also, I've created a Jalopy configuration file which contains pretty
printing
> information (including LGPL headers) which is referenced from:
> http://geotools.org/gt2docs/developersguide.html#jalopy
I used it few weeks ago, when you first time announced it.
Applied it to all my sources and genereally it works well but there are some
places where it could do it better.
I don't know if you have changed config file during last weeks but bellow
I will present some of them:
1. Some sources became not compilable because Jalopy included
    String "DOCUMENT ME!" with out before public static final
    variables (contants) without comment characters.
2. Some places are formated not very well. i. e.:
    I had:

    public TableRow(RowField[] fieldsArr, HashMap fieldsMap) {

    And got instead:

    public TableRow(
        RowField[] fieldsArr,
        HashMap fieldsMap
    ) {

    Maybe it depends on particular preference but I prefer first.
    Or maybe second one is more readable indeed...

    And one question: If all of GeoTools developers or almost all of
GeoTools
    developets prefer 2 spaces indenting, why to use 4?
    I understand standards are imprtant and help a lot, but we can modify
general
    standards to better fit our particular needs.

> I have to admit that the Sun coding convensions were not as neat as I had
> hoped and I have changed a few things.  (I hope for the better).  It would
be
> good to get feedback on this.  Although if we can't guess concensus I
guess
> we will have to fall back on the Sun convensions.
Could you point these changes? I have read SUN standards, seen formated code
and can't find any important changes.

> It will probably be a while before I start on this, but I'm moving the
format
> of the Geotools Guide toward a Generic format in anticipation of creating
a
> Generic Guide.
I am interested in it but I don't know what is Generic format. Could you
send some url to document describing it?

Artur
--
Artur Hefczyc                                art...@pl...
Open Source Developer
http://geotools.sourceforge.net/
http://wttools.sourceforge.net/