[Geotools-devel] First comments: about interface DataSource

[Martin D. <mar...@te...>]

Me again!


Interface DataSource
-----------------------------------------------------------
About the following DataSource method:

     public void stopLoading()

What about renaming it "abort"? It would be consistent with Image I/O 
API (javax.imageio.ImageReader). I also wonder: does it apply only to 
loading (in this case "abortLoading" may be fine) or could it be applied 
on exporting too (in which case "abort" is more general)?




Exception DataSourceException
-----------------------------------------------------------
The DataSourceException currently has only one constructor:

public DataSourceException(String msg)

The following constructor would be useful:

public DataSourceException(String msg, Throwable cause)

It would allows to use the chained-exception facility in J2SE 1.4 
implementation. It make it possible to specify e.g. that the cause of a 
DataSourceException was an IOException (or a SQLException, or...)



	Martin.