From: Gabriel R. <gr...@op...> - 2012-03-08 15:17:36
|
Hello Adam, glad to hear you're working on that. Note though that I've been working on a new generation WFS datastore (unfortunately simple features only too), but you might one to join that module instead of hacking on the current one. Work is ongoing on this git branch [1]. It's incomplete though and I'll push to the svn wfs_ng module when it's good enough. In any case, feel free to take a look at it. It should be a better place where to do experimental stuff rather than the current wfs module, as both GeoServer and uDig depend on it. Cheers, Gabriel [1]<https://github.com/groldan/geotools/commits/wfs_ng> On Thu, Mar 8, 2012 at 4:35 AM, Adam Brown <ada...@cu...> wrote: > Hi all, > > I've noticed that my proposed solution (below) is incomplete incince > AbstractDataStoreFactory implements DataStoreFactorySpi which has > dependencies on DataStore (and in turn, SimpleFeatureType and > SimpleFeature). > > Can anyone please point me in the right direction to change this Factory > heirarchy in order to enable it to return a factory whose 'createDataStore' > method returns a data store that supports Feature and FeatureType instead of > SimpleFeature and SimpleFeatureType? > > Thanks again, > > > Adam Brown > CSIRO, Australia > > > ________________________________ > From: Adam Brown > Sent: 08 March 2012 11:12 > To: jde...@op...; gr...@op... > Cc: geo...@li... > Subject: Request approval for changes to: gt-wfs - org.geotools.data.wfs - > WFSDataStoreFactory.java > > To Justin, Gabriel > > I'm in the process of adding complex feature support for WFS to GeoTools > and, to this end, I would like to propose changes to the following file: > > gt-wfs - org.geotools.data.wfs - WFSDataStoreFactory.java > > At the moment WFSDataStoreFactory extends AbstractDataStoreFactory but I > would like to another class (WFSDataAccessFactory) inbetween these, such > that: > > WFSDataAccessFactory extends AbstractDataStoreFactory > WFSDataStoreFactory extends WFSDataAccessFactory > > The bulk of the code that currently resides in WFSDataStoreFactory would > move up to WFSDataAccessFactory with the main exception being > "createDataStore" which would remain in WFSDataStoreFactory. > > This would give me the ability to create a new implementation of > createDataStore in WFSDataAccessFactory that returns a data access that is > not coupled to simple types. > > Do either of you have any objections to this or alternative suggestions? I'm > still fairly new to this so please tell me if my approach is wrong. > > Kind regards, > > > Adam Brown > CSIRO, Australia -- Gabriel Roldan OpenGeo - http://opengeo.org Expert service straight from the developers. |