[Geotools-devel] Request approval for changes to: gt-wfs - org.geotools.data.wfs - WFSDataStoreFactory.java

[Adam B. <ada...@cu...>]

To Justin, Gabriel

I'm in the process of adding complex feature support for WFS to GeoTools and, to this end, I would like to propose changes to the following file:

    gt-wfs - org.geotools.data.wfs - WFSDataStoreFactory.java

At the moment WFSDataStoreFactory extends AbstractDataStoreFactory but I would like to another class (WFSDataAccessFactory) inbetween these, such that:

WFSDataAccessFactory extends AbstractDataStoreFactory
WFSDataStoreFactory extends WFSDataAccessFactory

The bulk of the code that currently resides in WFSDataStoreFactory would move up to WFSDataAccessFactory with the main exception being "createDataStore" which would remain in WFSDataStoreFactory.

This would give me the ability to create a new implementation of createDataStore in WFSDataAccessFactory that returns a data access that is not coupled to simple types.

Do either of you have any objections to this or alternative suggestions? I'm still fairly new to this so please tell me if my approach is wrong.

Kind regards,


Adam Brown
CSIRO, Australia