Re: [Geotools-devel] PostPreProcessFilterSplittingVisitor vs. SQLUnpacker

[Jody G. <jga...@re...>]

Not sure off the of my head - what does the @deprecated annotation tell 
you to use? Oh I see PostPreProcessFilterSplittingVisitor.
Looks like a case of duplication of code; and the community going with 
the one that had more tests and was maintained.

Asking around there was tones of stuff that SQLUnpacker did not do ... 
talking to Jesse we cannot remember the details right now.
Jesse has been fixing the PostPreProcessing but could not do all the 
simplification until he moves to trunk.

Looking at *both* these implementations I think they are an example of 
code reuse getting in the way of clarity. It would be nice to have a 
utility class that breaks down a Filter into just the part you can 
encode, and then directly encode the good part into SQL with confidence.

I would find it much more clear to make a class that does this in one 
pass; that is accepts a filter and outputs both an SQL statement and the 
leftover filter that could not be encoded. That way we do not split up 
decision making between two classes.

Cheers,
Jody



Farber, Saul (ENV) wrote:
> This is kind of a targeted question, but I'll throw it out to the list to see if anyone else can answer too.
>
> Why is SQLUnpacker deprecated?
>
> Looking at PostPreProcessFilterSplittingVisitor the only thing I can figure that it's doing that SQLUnpacker isn't doing is handling client-side transactions via a ClientTransactionAccessor.
>
> Is there something fundamentally flawed about SQLUnpacker?  I do have to say that SQLUnpacker is MUCH more clearly and concisely written.
>
> --saul
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Geotools-devel mailing list
> Geo...@li...
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>