Re: [Geotools-gt2-users] Poor placement of empty filter check

[Jody G. <jga...@re...>]

Thanks for noticing the code now looks like:

>     protected FeatureReader createFeatureReader(FeatureType schema,
>             org.opengis.filter.Filter postFilter, QueryData queryData) 
> throws IOException {
>        
>         // Thanks Shaun Forbes - moving exludes check earlier
>         if (postFilter == Filter.EXCLUDE) {
>             return new EmptyFeatureReader(schema);
>         }
>        
>         FeatureReader fReader = getJDBCFeatureReader(queryData);
>
>         if ((postFilter != null) && (postFilter != Filter.INCLUDE)) {
>             fReader = new FilteringFeatureReader(fReader, postFilter);
>         }
>
>        
>         return fReader;
>     }
For specific patches like this you can talk to the module maintainer - 
look in the pom.xml for the contact details.
(I got this above one covered - if it passes tests I can commit).

Cheers,
Jody

> Howdy,
>
> I've just noticed that the JDBC1DataStore creates a JDBCFeatureReader 
> and possibly a FilteringFeatureReader before checking for an empty 
> filter, surely the check (postFilter == Filter.ALL) should be done at 
> the start of the method before these objects are created.
>
> See:
> org.geotools.data.jdbc.JDBC1DataStore
> 	protected FeatureReader createFeatureReader(FeatureType schema, Filter 
> postFilter, QueryData queryData) throws IOException
>
>
> Cheers,
> Shaun
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Geotools-gt2-users mailing list
> Geo...@li...
> https://lists.sourceforge.net/lists/listinfo/geotools-gt2-users
>