From: Bharat M. <bh...@me...> - 2010-08-07 17:57:50
|
Oops, I did a pretty poor job there. Fixed and tested. I'll post back in the forums. Kevin Nehls wrote: > Looks like that may have broken something: > > http://gallery.menalto.com/node/97288 > > <http://gallery.menalto.com/node/97288>I get the same result. > > Kevin > > On Fri, Aug 6, 2010 at 8:17 PM, Bharat Mediratta <bh...@me... > <mailto:bh...@me...>> wrote: > > > Your comment: > > re: d3a161ca1bb388593e03bd5c57c60ea249b3fe8d... don't you need to put > > code into IdentityProvider::change_provider to insure that the new > > identity module shows up in the same place in the list as the user > > module > > Good point. I'm not really sure what to do about that; it's kind of > weird to replace one module with another one. I'm going to just leave > it the way it is for now (so the new module will get stuck at the end of > the list) and if it becomes a problem we can deal with that separately. > > I'm going to merge my branch to master under the assumption that this > was the worst thing you found :-) > > -Bharat > > Tim Almdal wrote: > > Bharat: looked at your changes and left u a note in the channel > > > > Tim > > > > On 8/6/2010 4:25 PM, Bharat Mediratta wrote: > >> > >> Ahem. Yes, apparently I have some copy/paste issues. Dave's > link is > >> correct :-) > >> > >> Dave Moore wrote: > >>> I think that bharat has some copy/paste issues. I think he means > >>> this url: > >>> > http://github.com/gallery/gallery3/commit/d3a161ca1bb388593e03bd5c57c60ea249b3fe8d > >>> > >>> > >>> Dave > >>> At 11:45 AM 8/6/2010, Bharat Mediratta wrote: > >>> > >>>> Tim, would you please review this change: > >>>> > >>>> http://bit.ly/9JRDzN > >>>> > >>>> It's in my branch currently. It bumps the gallery module to > version 32 > >>>> and adds a weight column so that we can specify module order. It > >>>> fixes > >>>> ticket #1272, will make the moduleorder contrib module > simpler, and is > >>>> discussed in http://gallery.menalto.com/node/97232 > >>>> > >>>> thanks! > >>>> -Bharat > >>>> > >>>> > >>>> > ------------------------------------------------------------------------------ > >>>> > >>>> This SF.net email is sponsored by > >>>> > >>>> Make an app they can't live without > >>>> Enter the BlackBerry Developer Challenge > >>>> http://p.sf.net/sfu/RIM-dev2dev > >>>> __[ g a l l e r y - d e v e l ]_________________________ > >>>> > >>>> [ list info/archive --> http://gallery.sf.net/lists.php ] > >>>> [ gallery info/FAQ/download --> http://gallery.sf.net ] > >>> > >>> > >>> > ------------------------------------------------------------------------------ > >>> > >>> This SF.net email is sponsored by > >>> Make an app they can't live without > >>> Enter the BlackBerry Developer Challenge > >>> http://p.sf.net/sfu/RIM-dev2dev __[ g a l l e r y - d e v e l > >>> ]_________________________ > >>> > >>> [ list info/archive --> http://gallery.sf.net/lists.php ] > >>> [ gallery info/FAQ/download --> http://gallery.sf.net ] > >>> > >> > >> > >> No virus found in this incoming message. > >> Checked by AVG - www.avg.com <http://www.avg.com> > >> Version: 9.0.851 / Virus Database: 271.1.1/3054 - Release Date: > 08/06/10 00:37:00 > >> > >> > > > > > ------------------------------------------------------------------------ > > > > > ------------------------------------------------------------------------------ > > This SF.net email is sponsored by > > > > Make an app they can't live without > > Enter the BlackBerry Developer Challenge > > http://p.sf.net/sfu/RIM-dev2dev > > > > > > > ------------------------------------------------------------------------ > > > > __[ g a l l e r y - d e v e l ]_________________________ > > > > [ list info/archive --> http://gallery.sf.net/lists.php ] > > [ gallery info/FAQ/download --> http://gallery.sf.net ] > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > __[ g a l l e r y - d e v e l ]_________________________ > > [ list info/archive --> http://gallery.sf.net/lists.php ] > [ gallery info/FAQ/download --> http://gallery.sf.net ] > > |