From: ozgreg <g2d...@ga...> - 2008-05-22 03:56:25
|
We are all time poor and I am not impressed with the finger pointing back to the WPG2 codebase when clearly Gallery2 has changed way the JS is being called so lets work together to understand the basics... Anyway onwards.. When the change was made, was the change traced/tested to see if the new way of loading JS will not have an effect in an embedded application? Are the new JS calls or the way you are loading them, documented so at least I can pull apart the change to understand the impact the change has caused because the code that is being executed to insert the JS into the Wordpress Page is about as basic as it gets so it is pretty hard to say hey the code is wrong.. // Merge Gallery2 HEAD Outputs Into WP Header if (isset($g2data['headHtml'])) { list($g2_title, $g2_css, $g2_javascript) = GalleryEmbed::parseHead($g2data['headHtml']); foreach ($g2_css as $wpg2_css) { echo "$wpg2_css \r\n"; } foreach ($g2_javascript as $wpg2_javascript) { echo "$wpg2_javascript \r\n"; } What is confusing to me, is when I debug this, via xdebug I can see the same wordpress page getting called three times as soon as the Gallery2 JS calls are echo'd is not a good thing and pretty clearly what is causing the unusual behaviour.. |