From: Alan H. <ala...@su...> - 2006-08-25 17:01:47
|
The only thing I can think of changes the impl so it doesn't do everything requested... if the change-password view is always available, and only the update-profile view is removed for locked users, then you can still show "Your Account" and know at least some view will be there if it is clicked. - Alan Jay Rossiter / Signe wrote: > > Alan Harder wrote: >> Looks good, just a few comments: >> >> - Perhaps core/module.inc should check isLocked in getUserAdminViews >> instead of getSystemLinks.. remember that watermark has a user admin >> view; the upcoming notification module will too. Of course, if >> these are not active it will be odd to have the Your Account link >> and no views to show.. not sure how best to solve that. >> > > Hrm. Yeah, I'm not sure, either. For the moment I've added the > check to getUserAdminViews, but left it in getSystemLinks as well. Does > anyone have a good idea on this? > > Other than this point of question, I think it's ready to commit. > > >> - Should UserChangePasswordController also give PERMISSION_DENIED >> for locked user? >> > > Yes, it should... fixed. > >> - Fix the phpdoc for var $locked in GalleryUser.class, it currently >> has copy/pasted "The User's language preference" >> > > I re-did that block so many times while I was trying to re-figure > the new schema upgrade process that I forgot the last time. :) Fixed. > >> - Hard to tell from diffs, but make sure indenting is tabs+[4spaces] >> (I suspect it's ok since I got my vim settings from you..) >> > > I'm running strictly-spaces (which is allowed in our guidelines) due > to the settings for my day-job. > > >> Jay Rossiter / Signe wrote: >> >>> Adds an option to AdminEditUser so that the admin can lock an account so >>> that the user can't edit their own information. >>> >>> http://sourceforge.net/tracker/index.php?func=detail&aid=1519344&group_id=7130&atid=357130 >>> >>> http://www.cothlamadh.net/~signe/.outgoing/locked-user.diff >>> >>> Includes a core bump and schema update. >>> >>> Adds tests for AdminEditUser, UserPreferences, and CoreModule >>> >>> GetSystemLinks test never considered regular users, only admins. This >>> includes two extra scenarios - normal users, and locked users. (With >>> and without 'Your Account' link) >>> >>> > -- > Jay Rossiter http://www.cothlamadh.net/ > cry...@co... > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > ------------------------------------------------------------------------ > > __[ g a l l e r y - d e v e l ]_________________________ > > [ list info/archive --> http://gallery.sf.net/lists.php ] > [ gallery info/FAQ/download --> http://gallery.sf.net ] |