From: Bharat M. <bh...@me...> - 2006-06-23 06:05:13
|
ozgreg wrote: > Thankyou for stepping in, basically we need Gallery2 to return an > image that will fit the max size, from my understanding this would > have to be a larger image resized down to fit the maxsized imageblock > parameter. I just committed what I call "exact size" support to the imageblock module. Instead of saying (eg) g2_maxSize=400 you'd say g2_exactSize=400 and it will return an image that is 400px on a side, up to and including using the original image, unless the original is smaller than 400px. (Actually technically speaking we use the preferred derivative which might be a rotated version of the original). I didn't put in any safety checks to tell you that you're pulling down the original, but I did document in the Site Admin page that this can cost you bandwidth. > I would also suggest that an optimisation of the existing code that > the thumbnail size be examined against the maxsized parameter and > only if the thumbnail is smaller should a search for midsized images > be performed which will save a few queries.. Excellent idea! I made it so. > We should also cater the situation of what to do should a midsized > image not exist (should we return an error?) or the thumbnail, I feel > returning the thumbnail is confusing and suggest a error would be > better but either way works for us.. An error would kind of suck because it will screw up your layout. I opted instead to (potentially) waste bandwidth by using the original version instead. I can change that, if you think it's appropriate, but it's the kind of thing that the album owner can fix by creating a resized version. > Thankyou for your time and support. No problem. I apologize for taking so long to get around to fixing this-- I know it's important to our users. > On a slightly personal note I have committed to finalising the > development of one final version of the WPG2 plugin to handle these > much requested changes and will exit being a developer of the WPG2 > plugin after this. I'm sorry to see you go. You've been a valuable member of our community and I wish you all the best with your next endeavour. I hope that the incredibly popular WPG2 effort keeps up its momentum in your absence, and that you can stop by from time to time to say hi :-) -Bharat |