From: Martin G. <mge...@mg...> - 2005-10-27 07:08:49
|
Bharat Mediratta <bh...@me...> writes: > Martin Geisler wrote: >> I'm very impressed with your code reviewing standards --- I've never >> seen anything like it before! > > Thanks! It slows us down sometimes, but I think that it's given us > a consistently higher quality of code. That's my impression too, from the little I've seen. Compared to other open source projects you guys seem to have a plan for a greater design whereas lots of other projects just add code until the stuff works. It makes you slower at first, but in the long run it's sure to be an advantage, and it certainly gives me a lot more confidence in using Gallery2 for my girlfriend's pictures :-) >> $i =3D $numberOfItemsImported =3D 0; >> while ($albumfields && >> $i < count($form['sourceAlbums'])^2 && >> !connection_aborted()) { >> >> [...] > > At first blush, I expected the loop to terminate early in some cases > so I tried to reproduce that. But I quickly found out that the ^ > operator has a lower precedence than the < operator, so that section > is the same as: > > ($i < count($form['sourceAlbums']) ^ 2 Hehe, I hadn't realised that! A very sneaky bug... :-) =2D-=20 Martin Geisler GnuPG Key: 0x7E45DD38 PHP Exif Library | PHP Weather | PHP Shell http://pel.sf.net/ | http://phpweather.net/ | http://mgeisler.net/ Read/write Exif data | Show current weather | A shell in a browser |