From: SourceForge.net <no...@so...> - 2012-11-29 18:59:09
|
Patches item #3589476, was opened at 2012-11-23 15:26 Message generated for change (Comment added) made by sbaldovi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=596650&aid=3589476&group_id=91293 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Sergio Baldoví (sbaldovi) Assigned to: Nobody/Anonymous (nobody) Summary: Disabling Spectranet code Initial Comment: Spectranet peripheral depends on POSIX threads and BSD sockets that might be a drawback for other ports. IMO we should at least check for the usability of these APIs and disable code from the build if necessary. Optionally, some flags for explicitly disabling this code would be handy. Another problem with POSIX threads is figuring out the different names and compiler flags used in various systems. Probably the best portable way is the AX_PTHREAD macro from the autoconf archive [1]. I've attached a patch that implements --without-pthread and --disable-sockets flags. Comments and suggestions are more than welcome. [1] http://www.gnu.org/software/autoconf-archive/ax_pthread.html ---------------------------------------------------------------------- >Comment By: Sergio Baldoví (sbaldovi) Date: 2012-11-29 10:59 Message: Committed by revision 4779. ---------------------------------------------------------------------- Comment By: Sergio Baldoví (sbaldovi) Date: 2012-11-26 05:46 Message: Oops! It should be $sockets, Spectranet requires both threads and sockets. Thank you. ---------------------------------------------------------------------- Comment By: Fredrick Meunier (fredm) Date: 2012-11-26 03:31 Message: Is there a missing definition of $network in the patched configure.ac? ---------------------------------------------------------------------- Comment By: Sergio Baldoví (sbaldovi) Date: 2012-11-25 14:27 Message: Thank you. I will commit it in a few days if there are no more comments. ---------------------------------------------------------------------- Comment By: Fredrick Meunier (fredm) Date: 2012-11-24 04:21 Message: Looks fine to me. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=596650&aid=3589476&group_id=91293 |