Menu
▾
▴
[fuse-emulator-devel] [ fuse-emulator-Patches-3201532 ] Adjusting dialogs in Win32 UI because of themes
|
From: SourceForge.net <no...@so...> - 2011-03-19 11:37:04
|
Patches item #3201532, was opened at 2011-03-07 06:52 Message generated for change (Settings changed) made by fredm You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=596650&aid=3201532&group_id=91293 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending >Resolution: Accepted Priority: 5 Private: No Submitted By: Sergio Baldovi (sbaldovi) Assigned to: Nobody/Anonymous (nobody) Summary: Adjusting dialogs in Win32 UI because of themes Initial Comment: Dialogs: - Increase height and spacing of combobox in dialogs due to Visual Styles in Vista/7. - Standarized buttons width in autogenerated dialogs. - Added an About dialog, similar to GTK UI - In joystick options, increased the height of joystick types frame to allocate Fuller - Identified a bug with joystick buttons higher than four. Debugger: - Visual styles in Vista/7 increase rows height in ListView controls. Adjusted lists and dialog size to allocate 20 rows without scrolling (stack). - Disassembly list shows 20 rows in Vista/7, however shows 24 rows in 2000/XP to use full height. - Properly shown T-states, before was partially visible. - Fixed scrolling in disassembly list (1 LINEUP/LINEDOWN), don't mismatch next OP if the top OP was 2 bytes. - Enabled ESC key to close the dialog If anyone wants to test these changes, fuse-beta-20110306.zip contains a binary build. ---------------------------------------------------------------------- >Comment By: Fredrick Meunier (fredm) Date: 2011-03-19 22:37 Message: Thanks, committed in revision 4321. ---------------------------------------------------------------------- Comment By: Fredrick Meunier (fredm) Date: 2011-03-15 23:11 Message: Well I can't see an issue with the license as is, so will move to a "silence is assent" approach :) I'll commit this weekend barring objections. ---------------------------------------------------------------------- Comment By: Fredrick Meunier (fredm) Date: 2011-03-07 13:02 Message: Changes look good to me, I just would like to get Phil to confirm he is comfortable with the "CodeGuru" licensed files in the patch. Phil: the comment describes the issue as follows; it seems to be GPL-compatible to me, can you offer your opinion? + Taken (almost) verbatim from public domain code found on CodeGuru: + http://www.codeguru.com/cpp/controls/staticctrl/article.php/c5803 + Copyright 2002 Neal Stublen + All rights reserved. + + The CodeGuru license is a bit vague, but they state: + "While we are talking about copyrights, you retain copyright of your + article and code, but by submitting it to CodeGuru you give permission + to use it in a fair manner and also permit all developers to freely use + the code in their own applications -even if they are commercial." + License: CodeGuru-specific, 2009 ---------------------------------------------------------------------- Comment By: Sergio Baldovi (sbaldovi) Date: 2011-03-07 07:13 Message: Win32 beta binary is available here: http://www.megaupload.com/?d=PXGY3O2E Seems too large for SourceForge... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=596650&aid=3201532&group_id=91293 |