[Freeorion-programmers] [ freeorion-Bugs-1496647 ] Repeated Planet Name in Home System

[SourceForge.net <no...@so...>]

Bugs item #1496647, was opened at 2006-05-28 20:07
Message generated for change (Comment added) made by tzlaine
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1496647&group_id=75752

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Latest Subversion
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Geoff Topping (geoffthemedio)
Assigned to: Nobody/Anonymous (nobody)
Summary: Repeated Planet Name in Home System

Initial Comment:
In both RC4 and SVN, after starting a game with an
otherwise default-settings 10 star galaxy, in the
player's home system, there are two planets named
"SystemName I".  This doesn't seem to happen in any
other systems, including other empires' home systems,
though I didn't check thoroughly.

----------------------------------------------------------------------

Comment By: Zach Laine (tzlaine)
Date: 2006-10-21 14:15

Message:
Logged In: YES 
user_id=729903

Fixed in Subversion.

----------------------------------------------------------------------

Comment By: Geoff Topping (geoffthemedio)
Date: 2006-06-10 17:31

Message:
Logged In: YES 
user_id=913462

RC4 is not a release version.  It's a "hey look, stuff has
gotten done, but it's not enough for a full release version"
version, which is intended for testing primarily, so retains
the standard SVN non-randomness setting.  There's a #define
or a flag somewhere you can set if you want to compile with
really random number generation... I'm not sure where off
the top of my head, though.

Delete is a function of the Universe class, it's not delete
the built-in C++ keyword.  The logic above that line
(should) ensure(s) that there is a planet there to Delete,
and the Delete function would throw an exception of there
was no object for what's passed to it.

Note that the name give to the new planet is generated by
some logic based on the planet's slot, rather than taking
the the to-be-Deleted planet's name and re-applying that to
the replacement.  Doing this presumably prevents a homeworld
from being called "Asteroid Belt" in a few cases, but it
might also be allowing some faulty naming logic to slip past
in some cases.

The other issue is why it's necessary to Delete the planet
at all, rather than just change its terrain type and size to
that desired for the homeworld... which would probably be a
lot simpler.  There's still be the naming issue for asteroid
belts, but one might then just instruct the algorithm to not
pick asteroid belts to turn into homeworlds...

----------------------------------------------------------------------

Comment By: guardian24 (guardian24)
Date: 2006-06-10 16:30

Message:
Logged In: YES 
user_id=1536944

Maybe, but this was under 0.3.1 RC4 (Rev 1804).

Btw, this is the line that should always delete the 
replaced planet:

Delete(system->FindObjectIDsInOrbit<Planet>
(home_orbit).back());

But the return value of FindObjectIDsInOrbit is never 
checked?

----------------------------------------------------------------------

Comment By: Geoff Topping (geoffthemedio)
Date: 2006-06-10 15:14

Message:
Logged In: YES 
user_id=913462

Nonrandomness in SVN versions is not a bug.  See 1293761 :
http://sourceforge.net/tracker/index.php?func=detail&aid=1293761&group_id=75752&atid=544942

----------------------------------------------------------------------

Comment By: guardian24 (guardian24)
Date: 2006-06-10 15:08

Message:
Logged In: YES 
user_id=1536944

Well, i the same error happened with Cluster type, but with 
11+ systems. :(
Also, resigning then recreating the game: Sometimes it 
gives exactly the same planets and have the duplicate name, 
too.

----------------------------------------------------------------------

Comment By: guardian24 (guardian24)
Date: 2006-06-10 13:28

Message:
Logged In: YES 
user_id=1536944

After some checking, it seems that the problem only occurs 
when the galaxy type is set to spiral and the number of 
systems is 10.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1496647&group_id=75752