[Freeorion-programmers] [ freeorion-Bugs-1500294 ] Fleet Arrival Sitrep ERROR if Fleet Lost

[SourceForge.net <no...@so...>]

Bugs item #1500294, was opened at 2006-06-03 20:39
Message generated for change (Comment added) made by geoffthemedio
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1500294&group_id=75752

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Latest Subversion
Status: Open
Resolution: None
Priority: 3
Submitted By: Geoff Topping (geoffthemedio)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fleet Arrival Sitrep ERROR if Fleet Lost

Initial Comment:
If a fleet arrives in a system where another empire's
combat fleet is waiting, and the arriving fleet is
destroyed, the destroyed fleet's player gets a sitrep
message about the fleet arriving, but since the fleet
was destroyed, the listed fleet is "ERROR"

----------------------------------------------------------------------

>Comment By: Geoff Topping (geoffthemedio)
Date: 2006-06-09 07:58

Message:
Logged In: YES 
user_id=913462

Yes, that's the initial part of what's happening...  The
sitrep gets generated on the server with a reference to a
fleet, and is then sent to and decoded by the client.  If
the fleet is destroyed after the sitrep is generated, then
the universe that the server sends to the client does not
contain that fleet.  Then, when the sitrep's text is
generated by the client, it searches for the fleet
referenced in the sitrep, but can't find it because it's not
in the client's local universe.

To resolve this, I'm in the midst of adding to the Universe
class a map of "deleted objects" that is sent to players. 
This will have a few benefits, including fixing this sitrep
bug, and also making it possible for clients ot have a list
of all UniverseObjects that they know have been destroyed,
such as their own fleets, ships, planets, etc.

----------------------------------------------------------------------

Comment By: guardian24 (guardian24)
Date: 2006-06-09 07:50

Message:
Logged In: YES 
user_id=1536944

It is possible, as the Sitrep entry is added at the 
Movement phase, which is before the Combat phase.
This Sitrep is added at line 1766 in ServerApp.cpp.
I suggest adding a new Sitrep: "Fleet A arrived at sytem B, 
but was destroyed by the C empire's fleet." :))

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=544942&aid=1500294&group_id=75752