RE: [Freeorion-programmers] a few questions

[Zach L. <wha...@ho...>]

>From: "Marijn" <m.j...@st...>
>To: fre...@li...
>Subject: [Freeorion-programmers] a few questions
>Date: Wed, 25 Feb 2004 19:46:25 +0100 (CET)
>
>A few things...
>
>There seem to be quite some places in the source where pairs of
>coordinates are used. Right now these are often represented as
>std::pair<double, double> or as two separate variables. Is there anything
>against introducing a vector class specially for this? I have written one
>myself that has been used in quite a few programs already, you can take a
>look at it at http://www.student.kun.nl/m.j.haverbeke/vector2.h (there is
>also a vector3.h for 3-dimensional vectors in the same directory, might be
>useful later on). It is a template that groups two variables together and
>allows arithmetic operations on them, comes with typedefs for the commonly
>used scalar types. I've found it makes arithmetic with vectors a lot more
>straightforward and readable (std::pair<int, int> becomes Vector2i,
>pos.first() becomes pos.x()). I'll volunteer for updating current code to
>use this class...

I don't see any reason for this.  There's no need to reinvent the wheel.  
Also, a class is inappropriate here.  The whole reason for std::pair, and 
the reason it is used here, is that it is a convenient way of strapping 
together two objects, nothing more.  When there is no reason to add any 
invariants or operations on the data, a POD struct beats a class any day.


>On the forum Noelte asked me to take a look at the elliptical galaxy
>generation. I messed with it a little and I think my new version is nice,
>but I was wondering whether there are any short time plans for introducing
>variable-size galaxies. Right now galaxy size seems to be a contant, and
>it is really hard to get good-looking results when cramming hundreds of
>stars into the current (rather small) area.

It would be great if we could have all the sizes work properly.  Currently 
there is a dirty hack in place that handles the size, and badly at that.  
Start work on this if you like.


>Also, on my computer there seems to be a bug that causes the game to think
>the mouse is somewhat higher than it actually is (if I am making any
>sense), I have to click under buttons to press them. I have the latest
>version of GiGi (got it from its CVS two days ago), and of the other
>libraries I use the versions that came with the windows kit file from the
>CVS.

Track this down if you can.  I have never heard this reported by anyone 
else.

Zach

_________________________________________________________________
Click, drag and drop. My MSN is the simple way to design your homepage. 
http://click.atdmt.com/AVE/go/onm00200364ave/direct/01/