Thread: [Freemind-developer] Folding symbols
A premier mind-mapping software written in Java
Brought to you by:
christianfoltin,
danielpolansky
From: Christian F. (GMX) <chr...@gm...> - 2008-11-06 18:49:24
|
Dear Dimitry, taking the map freemind.mm you see "Modes" on the left side and the folding mark isn't at the right place. I've tracked it down to the method void paintFoldingMark(Graphics2D g, Point p) { final int zoomedFoldingSymbolHalfWidth = getZoomedFoldingSymbolHalfWidth(); // if(p.x == -1){ // p.x -= 2 * zoomedFoldingSymbolHalfWidth; // } // else if(p.x == getWidth()){ // p.x += 2 * zoomedFoldingSymbolHalfWidth; // } super.paintFoldingMark(g, p); } and commenting out the parts as above, the position is correct. Do you know, what the intention of the lines was? TIA, Chris |
From: Dimitry P. <dpo...@gm...> - 2008-11-06 21:51:44
Attachments:
Modes.png
|
Dear Chris, I interpret you in the sense that folding mark is placed wrong on node "About modes" of the English version of FreeMind documentation map. Well, I started my local freemind version, selected the mentioned node and obtained the attached picture. Here I see two noticeable points: 1. the folding marl seems to be placed correctly in the middle of the low left corner of the selected node. 2. The node is laid out so that it occupies more place than necessary. Actually it is a work around for zoomed maps. Java itself is not very exact in calculating font size here, so I just reserved a bit more place for making sure everything is likely to be printed well. See freemind bug [ 1788084 ] Characters only partly shown on zoom<>100% for more info. So I do not see any need of improvements in the issue you have raised. Kind regards, Dimitry > Dear Dimitry, > > taking the map freemind.mm you see "Modes" on the left side and the > folding mark isn't at the right place. > I've tracked it down to the method > > void paintFoldingMark(Graphics2D g, Point p) { > final int zoomedFoldingSymbolHalfWidth = > getZoomedFoldingSymbolHalfWidth(); > // if(p.x == -1){ > // p.x -= 2 * zoomedFoldingSymbolHalfWidth; > // } > // else if(p.x == getWidth()){ > // p.x += 2 * zoomedFoldingSymbolHalfWidth; > // } > super.paintFoldingMark(g, p); > } > > and commenting out the parts as above, the position is correct. > Do you know, what the intention of the lines was? > > TIA, Chris > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Freemind-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freemind-developer > |
From: Christian F. (GMX) <chr...@gm...> - 2008-11-07 06:47:03
|
Hi Dimitry, please, try again with the latest doc map. Regards, Chris Dimitry Polivaev schrieb: > Dear Chris, > > I interpret you in the sense that folding mark is placed wrong on node > "About modes" of the English version of FreeMind documentation map. > Well, I started my local freemind version, selected the mentioned node > and obtained the attached picture. Here I see two noticeable points: > > 1. the folding marl seems to be placed correctly in the middle of the > low left corner of the selected node. > > 2. The node is laid out so that it occupies more place than necessary. > Actually it is a work around for zoomed maps. Java itself is not very > exact in calculating font size here, so I just reserved a bit more > place for making sure everything is likely to be printed well. See > freemind bug [ 1788084 ] Characters only partly shown on zoom<>100% > for more info. > > So I do not see any need of improvements in the issue you have raised. > > Kind regards, > Dimitry > >> Dear Dimitry, >> >> taking the map freemind.mm you see "Modes" on the left side and the >> folding mark isn't at the right place. >> I've tracked it down to the method >> >> void paintFoldingMark(Graphics2D g, Point p) { >> final int zoomedFoldingSymbolHalfWidth = >> getZoomedFoldingSymbolHalfWidth(); >> // if(p.x == -1){ >> // p.x -= 2 * zoomedFoldingSymbolHalfWidth; >> // } >> // else if(p.x == getWidth()){ >> // p.x += 2 * zoomedFoldingSymbolHalfWidth; >> // } super.paintFoldingMark(g, p); >> } >> >> and commenting out the parts as above, the position is correct. >> Do you know, what the intention of the lines was? >> >> TIA, Chris >> >> >> ------------------------------------------------------------------------- >> >> This SF.Net email is sponsored by the Moblin Your Move Developer's >> challenge >> Build the coolest Linux based applications with Moblin SDK & win >> great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the >> world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> _______________________________________________ >> Freemind-developer mailing list >> Fre...@li... >> https://lists.sourceforge.net/lists/listinfo/freemind-developer >> > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > ------------------------------------------------------------------------ > > _______________________________________________ > Freemind-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freemind-developer > |
From: Dimitry P. <dpo...@gm...> - 2008-11-08 13:51:34
Attachments:
Modes.png
|
Hi Chris, everything looks good with the new map version too. I do not see any problems. I suppose you to post here a screen shot demonstrating what you do not like. Dimitry > Hi Dimitry, > > please, try again with the latest doc map. > > Regards, Chris > > Dimitry Polivaev schrieb: >> Dear Chris, >> >> I interpret you in the sense that folding mark is placed wrong on node >> "About modes" of the English version of FreeMind documentation map. >> Well, I started my local freemind version, selected the mentioned node >> and obtained the attached picture. Here I see two noticeable points: >> >> 1. the folding marl seems to be placed correctly in the middle of the >> low left corner of the selected node. >> >> 2. The node is laid out so that it occupies more place than necessary. >> Actually it is a work around for zoomed maps. Java itself is not very >> exact in calculating font size here, so I just reserved a bit more >> place for making sure everything is likely to be printed well. See >> freemind bug [ 1788084 ] Characters only partly shown on zoom<>100% >> for more info. >> >> So I do not see any need of improvements in the issue you have raised. >> >> Kind regards, >> Dimitry >> >>> Dear Dimitry, >>> >>> taking the map freemind.mm you see "Modes" on the left side and the >>> folding mark isn't at the right place. >>> I've tracked it down to the method >>> >>> void paintFoldingMark(Graphics2D g, Point p) { >>> final int zoomedFoldingSymbolHalfWidth = >>> getZoomedFoldingSymbolHalfWidth(); >>> // if(p.x == -1){ >>> // p.x -= 2 * zoomedFoldingSymbolHalfWidth; >>> // } >>> // else if(p.x == getWidth()){ >>> // p.x += 2 * zoomedFoldingSymbolHalfWidth; >>> // } super.paintFoldingMark(g, p); >>> } >>> >>> and commenting out the parts as above, the position is correct. >>> Do you know, what the intention of the lines was? >>> >>> TIA, Chris >>> >>> >>> ------------------------------------------------------------------------- >>> >>> This SF.Net email is sponsored by the Moblin Your Move Developer's >>> challenge >>> Build the coolest Linux based applications with Moblin SDK & win >>> great prizes >>> Grand prize is a trip for two to an Open Source event anywhere in the >>> world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> _______________________________________________ >>> Freemind-developer mailing list >>> Fre...@li... >>> https://lists.sourceforge.net/lists/listinfo/freemind-developer >>> >> >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------- >> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge >> Build the coolest Linux based applications with Moblin SDK & win great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Freemind-developer mailing list >> Fre...@li... >> https://lists.sourceforge.net/lists/listinfo/freemind-developer >> > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > ------------------------------------------------------------------------ > > _______________________________________________ > Freemind-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freemind-developer |
From: Christian F. (GMX) <chr...@gm...> - 2008-11-09 07:32:29
Attachments:
modes.png
|
Hi Dimitry, with the original code I get: The folding symbol is at the wrong place, isn't it? Regards, Chris |
From: Dimitry P. <dpo...@gm...> - 2008-11-09 09:16:48
Attachments:
ModesCorrected.png
|
Hi Chris, your picture contained enough information for analyzing the problem. Try the following corrected function and decide whether you like it more.It's purpose is to completely shift the folding mark location out of the node. (You can replace System.err.println through logger call if you like). void paintFoldingMark(Graphics2D g, Point p) { final int zoomedFoldingSymbolHalfWidth = getZoomedFoldingSymbolHalfWidth(); if(p.x == getX()){ p.x -= zoomedFoldingSymbolHalfWidth; } else if(p.x == getX() + getWidth() - 1){ p.x += zoomedFoldingSymbolHalfWidth; } else { System.err.println("unexpected folding mark location " + p); } super.paintFoldingMark(g, p); } > Hi Dimitry, > > with the original code I get: > > The folding symbol is at the wrong place, isn't it? > > Regards, Chris > > > ------------------------------------------------------------------------ > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > ------------------------------------------------------------------------ > > _______________________________________________ > Freemind-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freemind-developer |
From: Christian F. (GMX) <chr...@gm...> - 2008-11-12 21:44:58
|
Hi Dimitry, integrated, although it seems to me, that this correction should happen in getMainViewOutPoint(NodeView, NodeView, Point), or am I wrong? Regards, Chris Dimitry Polivaev schrieb: > Hi Chris, > > your picture contained enough information for analyzing the problem. > Try the following corrected function and decide whether you like it > more.It's purpose is to completely shift the folding mark location out > of the node. (You can replace System.err.println through logger call > if you like). > > void paintFoldingMark(Graphics2D g, Point p) { > final int zoomedFoldingSymbolHalfWidth = > getZoomedFoldingSymbolHalfWidth(); > if(p.x == getX()){ > p.x -= zoomedFoldingSymbolHalfWidth; > } > else if(p.x == getX() + getWidth() - 1){ > p.x += zoomedFoldingSymbolHalfWidth; > } > else { > System.err.println("unexpected folding mark location " + p); > } > > super.paintFoldingMark(g, p); > } > >> Hi Dimitry, >> >> with the original code I get: >> >> The folding symbol is at the wrong place, isn't it? >> >> Regards, Chris >> >> >> ------------------------------------------------------------------------ >> >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------- >> >> This SF.Net email is sponsored by the Moblin Your Move Developer's >> challenge >> Build the coolest Linux based applications with Moblin SDK & win >> great prizes >> Grand prize is a trip for two to an Open Source event anywhere in the >> world >> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Freemind-developer mailing list >> Fre...@li... >> https://lists.sourceforge.net/lists/listinfo/freemind-developer > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > ------------------------------------------------------------------------ > > _______________________________________________ > Freemind-developer mailing list > Fre...@li... > https://lists.sourceforge.net/lists/listinfo/freemind-developer > |
From: Dimitry P. <dpo...@gm...> - 2008-11-13 20:36:48
|
Hi Chris, the folding symbol is painted at another place than the "out point", and this place depends on the node shape (fork or bubble). Regards, Dimitry Christian Foltin (GMX) schrieb: > Hi Dimitry, > > integrated, although it seems to me, that this correction should happen > in getMainViewOutPoint(NodeView, NodeView, Point), or am I wrong? > > Regards, Chris > > Dimitry Polivaev schrieb: |