Re: [freedos-32-dev] Kernel parameter changes

[Hanzac C. <ha...@gm...>]

Hi, Nils

Nils Labugt wrote:
> 
> params.h and params.c is missing in the repository, and the kernel does
> not build.
Sorry, I forgot that they haven't been added to the repository. I'll do
that right now.

> Nice to have some generalized command line processing.
> 
> A couple ideas/suggestions:
> 
> - Maybe code size would be a little smaller if the parameters was
> initialized statically similarly to the syscall table. (It would not
> make much difference if there is few parameters.)
Yes, you're right. But only need to remove two lines of code:
   set_param("coff", NULL, COFF_set_type);
   set_param("tick", NULL, Timer_set);
and set the param_table like this:
static fd32_param_t param_table[8] = {
   {"coff", NULL, COFF_set_type},
   {"tick", NULL, Timer_set},
};
Currently, don't have much difference. I agree that :-)
How about choosing the right method after we have some more params?

> - What about exporting this functionality so that the modules can use
> it? Then we could add configuration file support later witch would
> (could) be transparent to the modules.
But currently, it's not convenient 'cause if the filesystem modules aren't
loaded the kernel can't access the files.

I'm thinking about regarding the config file as text-file module and
load it through the grub.

>>Currently supported parameters and its value range:
>>--tick=<0 - 50000>
>>--coff=<djcoff, pecoff>
>>
> 
> We will probably need extra parameters for memory management and timers.
I don't know much about them, if you like you can give the params.

Thanks,
Hanzac