From: Matthew T. <mat...@go...> - 2009-08-21 06:40:05
|
I think some kind of peek at the file is inevitable. We could more generally use it to work out what site it's from? 2009/8/20 Eric Blade <bla...@gm...> > is the code that only converts new hands up to snuff yet? haven't > tried it.. if it is, i don't see that there would really be much > problem with that test.. although i can't think of any better way > offhand.. i suppose we could use file time.. but that really isn't > much of a guaarntee.. > > > On Thu, Aug 20, 2009 at 4:53 PM, Unknown<ray...@hu...> wrote: > > OK, I've been grouchy for a week thinking about how to fix the FTP HH > > import. I have not come up with a good solution. Here's what I think: > > > > _Background_ FTP HHs are now encoded in utf-16. Setting the codepage > > string to utf-16 imports those HHs ok, but causes HHs older than last > > month to fail. > > > > _Proposal_ We need to be able to test HHs for the encoding. We could do > > this by setting the codepage variable to "test" and implementing a > > method in FullTiltToFpdb.py to do the testing. It is easy to test for > > encoding when the BOM is implemented(it is implemented by FTP): > > > >>>> import codecs > >>>> f = open('utf16.txt') > >>>> s = f.read(4) > >>>> s > > '\xff\xfeF\x00' > >>>> (s.startswith(codecs.BOM_UTF16_LE)) > > True > > > > So we would have a method that opens the new HH file to be processed, > > tests it, closes it, and returns a codepage string. This is not pretty > > and will slow down imports, but is the best I can come up with. > > > > We know that autoimports are utf-16, so we could short circuit the test > > for auto imports, but that makes the code more complicated for a pretty > > small savings. > > > > If I don't hear a complaint soon, I'll go ahead and commit/push this. > > > > Thanks > > > > > > > ------------------------------------------------------------------------------ > > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > > trial. Simplify your report design, integration and deployment - and > focus on > > what you do best, core application coding. Discover what's new with > > Crystal Reports now. http://p.sf.net/sfu/bobj-july > > _______________________________________________ > > Fpdb-main mailing list > > Fpd...@li... > > https://lists.sourceforge.net/lists/listinfo/fpdb-main > > > > > > -- > Cheers, > - Eric > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus > on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Fpdb-main mailing list > Fpd...@li... > https://lists.sourceforge.net/lists/listinfo/fpdb-main > |