Re: [Flightgear-devel] Bug in panel

[John C. <j4s...@ro...>]

On Wed, 23 May 2001, Curtis L. Olson wrote:

> David, John, has this been fixed in the most recent panel changes?
>
> Curt.

Not that I can see. As a matter of fact after the panel changes were
committed, not only does visibility not toggle but on reload the offset
is lost. IOW the panel goes "fullscreen" and you have to scroll it down
with shift+F5. I sent a message to the list about it previously.

Somebody please confirm this, I'm about a week behind on my FG version.

TTYL
JC

>
>
> Martin Dressler writes:
> > When you reload panel by Shift-F3 you than can't switch panel on and off by
> > Shift-P this is due unproperly tie and untie /sim/panel/visibility
> >
> > in Main/keyboard.cxx ther is
> >         case GLUT_KEY_F3: {
> >             string panel_path =
> >                 fgGetString("/sim/panel/path", "Panels/Default/default.xml");
> >             FGPanel * new_panel = fgReadPanel(panel_path);
> >             if (new_panel == 0) {
> >                 SG_LOG(SG_INPUT, SG_ALERT,
> >                        "Error reading new panel from " << panel_path);
> >                 return;
> >             }
> >             SG_LOG(SG_INPUT, SG_INFO, "Loaded new panel from " << panel_path);
> >             current_panel->unbind();
> >             delete current_panel;
> >             current_panel = new_panel;
> > I added this line and it helps:
> >             current_panel->bind();  //Added by Madr
> >             current_panel->init();  //empty function
> >
> >             return;
> >         }
> >
> > But there are another problems
> > In destructor of FGPanel is also unbind() so it report error.
> > Maybe there should be some test if properties are still tied.
> >
> > In constructor of FGPanel there is call
> >  setVisibility(fgPanelVisible());
> > but fgPanelVisible() is dependant on _visibility variable,
> > and this variable isn't declared because at time of making new instance isn't
> > yet tied to property.
> > You cant simply tie vars to property because in GLUT_KEY_F3 handling exist
> > two instances of panel at one time.
> > I think that this call is useless and can be simply replaced by
> > _visibility(0) ;
> >
> > Regards,
> > Madr
> >
> > --
> >       Martin Dressler
> >
> > e-mail: dr...@mu...
> > http://www.musicabona.com/
> >
> > _______________________________________________
> > Flightgear-devel mailing list
> > Fli...@li...
> > http://lists.sourceforge.net/lists/listinfo/flightgear-devel
>
> --
> Curtis Olson   Human Factors Research Lab       FlightGear Project
> Twin Cities    cu...@hf...                cu...@fl...
> Minnesota      http://www.menet.umn.edu/~curt   http://www.flightgear.org
>
> _______________________________________________
> Flightgear-devel mailing list
> Fli...@li...
> http://lists.sourceforge.net/lists/listinfo/flightgear-devel
>