Re: [Flightgear-devel] encoder/altimeter & kap140.nas

[Dave P. <ski...@mi...>]

On Sat, 2007-03-03 at 08:31 +0100, Melchior FRANZ wrote:
> * Dave Perry -- Saturday 03 March 2007:
> > Have you asked to have atmo.diff applied to cvs?.
> 
> I don't think it can be applied as it is. I'm no physicist and
> can't comment on the logic, but there are some formal aspects
> to fix IMHO:
> 
In an off-list exchange with John Denker, I volunteered to make the
edits identified by Melchior to accelerate getting the atmo.*xx,
altimeter.*xx, and the mods to related files into cvs. He agreed to this
as the following excerpt from that exchange verifies:

> 1) Doing what you suggest is a good idea.  By that I mean it
>   is in the best interests of the user community.
> 
> 2) Open code is open code.  You do not need my permission to
>   do as you suggest ... however ...
> 
> 3) Since you more-or-less asked, the answer is yes, you have
>   my blessing.  I offer my help if you need it.
> 
I believe the requested edits have been made in the attached patch.

Just to be clear,

1)  This is an edit of my "hand implementation" of the last atmo.diff
from John.

2)  The kollsman shift is not saved to the property tree.

3)  The kap140.nas is updated to compute the baroShift only when the
baroSetting changes.  The baroShift is computed in kap140 and the
constants used are reconciled with the corresponding constants in
atmo.cxx and atmo.hxx.

4)  I did not change my bug fix to John's version of the fix for the
fgGetLowPass PA rounding bug.  His fix and mine are computational
equivalents.

Melchior, please look at the indents, etc. and if you see anything I
missed or misinterpreted, let me know.

Roy, please look at the changes to kap140.nas and make any
suggestions/comments.

John, any comments?

I compiled and tested the edited code.  Any other testing is welcome.
If there are no changes requested after a few days, would Melchior
please put this in cvs.

The last time I attached a patch, Sourceforge deleted it, so I will send
the patch off list to Melchior, Roy, and John just to be sure.