[Flightgear-devel] another hotspot fix/suggestion

[syd <syd...@te...>]

Hi all , 
Hotspots are back to normal ... almost.
They are now covered or hidden by some 3d objects , so I disabled the
Depth Test state  and it now works like the plib version , most
hotspots are visible again....
 I'm not sure how to create a proper patch file .... and Im not sure if
I have write access to the source , so I'll add a description of my
change to panel.cxx ...

starting line: 475

    if (!hotspotStateSet.valid()) {
      hotspotStateSet = new osg::StateSet;
      hotspotStateSet->setTextureMode(0,GL_TEXTURE_2D,osg::StateAttribute::OFF);
      hotspotStateSet->setMode(GL_LIGHTING,osg::StateAttribute::OFF);
 }

with change:

    if (!hotspotStateSet.valid()) {
      hotspotStateSet = new osg::StateSet;
      hotspotStateSet->setTextureMode(0,GL_TEXTURE_2D,osg::StateAttribute::OFF);
      hotspotStateSet->setMode(GL_LIGHTING,osg::StateAttribute::OFF);
     hotspotStateSet->setMode(GL_DEPTH_TEST,osg::StateAttribute::OFF);
 }

Cheers,
Syd

P.S. Already compiled and running on my system...

OK I should have know , my 'fix' improves hotspot visibilty , but not
completely ... I still get some that are partially hidden by 3d
objects , and some appear when near the edge of the screen , but are
partially hidden when in the view center .Interesting ... it's the same
effect I had with the weather radar.......
so I'll keep testing ....
Cheers,
Syd