Re: [Flightgear-devel] patch: some code (warnings) cleanup

[Markus B. <mb...@al...>]

On Sun, Aug 13, 2006 at 04:21:47PM +0200, Melchior FRANZ wrote:
> * Markus Barenhoff -- Sunday 13 August 2006 14:52:
> > if done some code cleanup included in the attached patch.
>=20
> Eew ... not a unified context diff.
> I'd be fine with most of this, except this:
>

it is the output of cvs diff... is there a cmd line option for creating
unified diffs?
=20
>=20
> RCS file: /var/cvs/FlightGear-0.9/source/src/GUI/dialog.cxx,v
> retrieving revision 1.87
> diff -r1.87 dialog.cxx
> 879c879
> <         ALT =3D 0x4,
> ---
> >         ALT =3D 0x4
>=20
>=20
> What's the problem with the trailing comma? It's there so that one
> can easily add more constants or move others around. This patch
> serves no purpose, other than to annoy developers.  :-}
>=20
ok your right... :)

> Being able to compile all of sg/fgfs without compiler warnings would
> be nice and would make real problems stick out. Of course, different
> compilers will show different warnings, and some may only be avoidable
> with adding ugly code, but ...
>=20

probably you are right at this point too, but sometimes i forget that
there are other compilers out there :)


cu Markus

--=20
Markus Barenhoff - phone: +49-40-39991368 - cell: +49-173-7215776
Stellinger Chaussee 26c - D-22529 Hamburg - Germany - Earth
url: http://www.alios.org/ -  mail: mb...@al...
pgpkey: 0xAE7C7759 fp: 79 64 AA D9 B7 16 F5 06  6A 88 5F A9 4D 49 45 BB