Re: [FCKeditor-Trac] [FCKeditor Dev] #2357: PropertiesLoader Exception when undeploying a webapp using FCKeditor.Java Integration

[<fck...@li...>]

#2357: PropertiesLoader Exception when undeploying a webapp using FCKeditor.Java
Integration
----------------------------+-----------------------------------------------
  Reporter:  SinuS          |       Owner:  mosipov           
      Type:  Bug            |      Status:  assigned          
  Priority:  Normal         |   Milestone:                    
 Component:  Server : Java  |     Version:  FCKeditor.Java 2.4
Resolution:                 |    Keywords:                    
----------------------------+-----------------------------------------------
Changes (by mosipov):

  * owner:  => mosipov
  * status:  new => assigned


Old description:

> Hello[[BR]]
> I think PropertiesLoader must be changed to something like this:[[BR]]
> [[BR]]
>

> {{{
> package net.fckeditor.handlers;
> import java.io.BufferedInputStream;
> import java.io.IOException;
> import java.io.InputStream;
> import java.util.Properties;
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
>
> public class PropertiesLoader {
>         private static final Logger logger =
> LoggerFactory.getLogger(PropertiesLoader.class);
>         private static Properties properties = new Properties();
>         static {
>                 try {
>                         InputStream in
> =PropertiesLoader.class.getResourceAsStream("default.properties");
>                         if(null == in) {
>                                 logger.warn("Can't find default
> properties!");
>                         } else {
>                                 properties.load(new
> BufferedInputStream(in));
>                                 logger.info("Default's properties loaded
> successfully!");
>                                 in.close();
>                         }
>                 } catch (IOException e) {
>                         logger.error("Error while loading default
> properties!", e);
>                         throw new RuntimeException("Can't load default
> properties!", e);
>                 } catch (NullPointerException e) {
>                         logger.error("Error while loading default
> properties!", e);
>                         throw new RuntimeException("Can't load default
> properties!", e);
>                 }
>                 try {
>                         InputStream in =
> PropertiesLoader.class.getResourceAsStream("/fckeditor.properties");
>                         if (null == in) {
>                                 logger.warn("Can't find user
> properties!");
>                         } else {
>                                 properties.load(new
> BufferedInputStream(in));
>                                 logger.info("User's properties loaded
> successfully!");
>                                 in.close();
>                         }
>                 } catch (IOException e) {
>                         logger.error("Error while loading user
> properties!", e);
>                         throw new RuntimeException("Can't load user
> properties!", e);
>                 } catch (NullPointerException e) {
>                         logger.error("Error while loading user
> properties!"+ e);
>                         throw new RuntimeException("Can't load user
> properties!", e);
>                 }
>         }
>         public static String getProperty(final String key) {
>                 return properties.getProperty(key);
>         }
>
>         public static void setProperty(final String key, final String
> value) {
>                 properties.setProperty(key, value);
>         }
> }
>

> }}}
>
> [[BR]] [[BR]]
>
> I just added '''in.close()''' because
> ''PropertiesLoader.class.getResourceAsStream'' throws an exception when i
> undeploy my webapps on glassfish ;)

New description:

 Hello[[BR]]
 I think PropertiesLoader must be changed to something like this:[[BR]]
 [[BR]]


 {{{
 package net.fckeditor.handlers;
 import java.io.BufferedInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.Properties;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

 public class PropertiesLoader {
         private static final Logger logger =
 LoggerFactory.getLogger(PropertiesLoader.class);
         private static Properties properties = new Properties();
         static {
                 try {
                         InputStream in
 =PropertiesLoader.class.getResourceAsStream("default.properties");
                         if(null == in) {
                                 logger.warn("Can't find default
 properties!");
                         } else {
                                 properties.load(new
 BufferedInputStream(in));
                                 logger.info("Default's properties loaded
 successfully!");
                                 in.close();
                         }
                 } catch (IOException e) {
                         logger.error("Error while loading default
 properties!", e);
                         throw new RuntimeException("Can't load default
 properties!", e);
                 } catch (NullPointerException e) {
                         logger.error("Error while loading default
 properties!", e);
                         throw new RuntimeException("Can't load default
 properties!", e);
                 }
                 try {
                         InputStream in =
 PropertiesLoader.class.getResourceAsStream("/fckeditor.properties");
                         if (null == in) {
                                 logger.warn("Can't find user
 properties!");
                         } else {
                                 properties.load(new
 BufferedInputStream(in));
                                 logger.info("User's properties loaded
 successfully!");
                                 in.close();
                         }
                 } catch (IOException e) {
                         logger.error("Error while loading user
 properties!", e);
                         throw new RuntimeException("Can't load user
 properties!", e);
                 } catch (NullPointerException e) {
                         logger.error("Error while loading user
 properties!"+ e);
                         throw new RuntimeException("Can't load user
 properties!", e);
                 }
         }
         public static String getProperty(final String key) {
                 return properties.getProperty(key);
         }

         public static void setProperty(final String key, final String
 value) {
                 properties.setProperty(key, value);
         }
 }


 }}}

 [[BR]] [[BR]]

 I just added '''in.close()''' because
 ''PropertiesLoader.class.getResourceAsStream'' throws an exception when i
 undeploy my webapps on glassfish ;)

--

Comment:

 SinuS, please try the attached jar. The in.close() is called there. If you
 verify this, I will close this ticket.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/2357#comment:>
FCKeditor <http://www.fckeditor.net/>
The text editor for Internet