From: Mike T. <mh...@us...> - 2003-08-25 20:30:01
|
Hello Alexey, First, I appreciate your time and effort in fixing the raid1-code. On Fri, 2003-08-22 at 11:25, Alexey Kotovich wrote: > Hi there; > > to begin with I'd like to outline that I am working for OptiFacio Inc company > that produces software for NAS. We have been using EVMS in our product since > 1.0.0 version (don't remember exactly though :) EVMS is great software and > I'd like to say "Thank you!". It is very useful thing escpecially for such products > like we do. Despite a lot of workarounds we had made being used EVMS it is still > incorporated in our system. Thus we are interested in improving and extending > EVMS's functionality. EVMS is an open source project. We are very happy when users point out problems and developers provide fixes and enhancements. > > Unfortunately, there are several issues in evms-2.x with regard to Raid1-5 > subsystem (md plugin). For example, there was possible to add active disk > to Raid region even if it had Volume on top of it in evms-1.2.x but now it is just > desirable. The kernel MD developer, Neil Brown, fixed this problem on the kernel side. The current evms-2.1.1 should have a patch for the kernel md driver. > Second example is that it is unable to Fix array, to be precise, > write changes on the superblock in some situations.. let say at all ;) So, Fix > functionality is also is not available. Yes, you're right. As I admitted before there is a problem in both raid1 and raid5 "fix" code. > > Well, I am not going to describe all hidden catches which we are experienced in > because I am too lazy for that (frankly, I merely don't remember all of them :). > I just want to offer patch that resolve those problem for Raid1 region (I hope > I'll be able to review Raid0,5 regions too) > > The changes which this patch provides are as follows: > > - ability to fulfil "add active disk" when region has consuming objects; > - stop/start functions were added; > - check function is available in task list too; > - raid1_create() was changed slightly; > - raid1_verify_and_fix_array() was changed totally; > - I am sorry for changing code layout ;) No problem. I am happy to review the new code layout. > - procedure of activating spare/adding new disk was changed; > - expand/shrink functionality was moved to separated file raid1_resize.c; > and some others minor changes.. > > I also have a plan to add some enbd functionality to Raid1 region manager. > > So, patch is for your consideration. It is against evms-2.1.0 but I think > it can be applied to evms-2.1.1 too. > > One more thing.. I'd like to point out that evms-2.1.0 with this patch > is included in latest version of our product and being hard tested > in our lab... and as a result it is still under development :) > > Patch is within. > > regards, > Alexey ICQ:97715595 I will try your patch sometime next week for I am still busy with other projects until for another week. Thanks, Mike Tran |