From: dpp-gerrit <dpp...@us...> - 2015-09-21 16:18:12
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit. The branch, master has been updated via 859b282eb6a1b17b24d5f4c6c22e1cf83f89cdfb (commit) via d03e5061fef3946ed2555404230b835cb1391076 (commit) via 122a67c868ae5f74abc10dd81a80b0647e541920 (commit) from b7fb2c272eec69156a3eb97fdf52b21d733a0ad2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 859b282eb6a1b17b24d5f4c6c22e1cf83f89cdfb Author: Franz Zieris <zi...@in...> Date: Fri Sep 18 17:17:54 2015 +0200 [INTERNAL] Rename local variable in EditorManager.execViewport() The old name was 'userWithWriteAccessSelection', the new one is 'selection'. The change makes the method easier to read. Change-Id: I091177fcbb23ed51480415b85c2f66b0d41945f2 Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/2887 Tested-by: Jenkins CI Reviewed-by: Stefan Rossbach <sro...@ar...> commit d03e5061fef3946ed2555404230b835cb1391076 Author: Franz Zieris <zi...@in...> Date: Wed Aug 26 19:56:21 2015 +0200 [NOP] Remove unused methods from SarosSessionStub This patch removes seven methods without an @Override annotation from the stub implementation of ISarosSession. Change-Id: I70f126f2fc20e64cc5cfaa344c23fc58a1af5b5a Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/2883 Tested-by: Jenkins CI Reviewed-by: Stefan Rossbach <sro...@ar...> commit 122a67c868ae5f74abc10dd81a80b0647e541920 Author: Franz Zieris <zi...@in...> Date: Wed Aug 26 19:30:41 2015 +0200 [NOP] Remove some outdated TODOs - ISessionListener: It has been there since f0e78dd (2006-09-03), and nobody cared about it. - SarosEclipseContextFactory: This class *is* as Eclipse-specific as it gets. - EditorManager: Has been there since 302506f (2009-02-15) and no one cared. - EditorPool: Was meant for debugging, been there since b277020 (2010-04-29). Change-Id: If571e8b8efaf6c820df92f2bb2ecdde580fc936c Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/2886 Tested-by: Jenkins CI Reviewed-by: Stefan Rossbach <sro...@ar...> ----------------------------------------------------------------------- Summary of changes: .../inf/dpp/session/ISessionListener.java | 5 -- .../inf/dpp/test/stubs/SarosSessionStub.java | 43 -------------------- .../inf/dpp/SarosEclipseContextFactory.java | 4 +- .../de/fu_berlin/inf/dpp/editor/EditorManager.java | 40 +++++------------- .../de/fu_berlin/inf/dpp/editor/EditorPool.java | 3 - 5 files changed, 12 insertions(+), 83 deletions(-) hooks/post-receive -- The Saros Eclipse Plugin |