Re: [Dpp-devel] Review Request: [FIX] #3472493: NPE with non-host inviter

[Alexander W. <co...@ne...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/235/#review862
-----------------------------------------------------------

Ship it!


The NPE-Fix is committed. Please close this review.

- Alexander


On Jan. 19, 2012, 12:48 p.m., Karl Beecher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://saros-build.imp.fu-berlin.de/reviews/r/235/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2012, 12:48 p.m.)
> 
> 
> Review request for Saros.
> 
> 
> Summary
> -------
> 
> The FreeColors class is not instantiated in non-hosts. This leads to a NPE.
> 
> NOTE: This is only intended as a fix for the NPE. When testing you will find that there are further problems with the colors. It seems that the assumption that the inviter is a host is littered throughout the code and causing problems.
> 
> I begun to investigate, but it turned out to be a bigger problem than I have time for. I will post my progress on the dpp-devel list.
> 
> 
> This addresses bug 3472493.
>     http://sourceforge.net/support/tracker.php?aid=3472493
> 
> 
> Diffs
> -----
> 
>   /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/internal/SarosSession.java 3705 
> 
> Diff: http://saros-build.imp.fu-berlin.de/reviews/r/235/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karl
> 
>