Menu
▾
▴
Re: [Dpp-devel] Review Request: Fixed: nonhost adding buddies to session and readonly users adding projects to session
|
From: Alexander W. <co...@ne...> - 2012-01-27 08:24:46
|
> On Jan. 24, 2012, 3:21 p.m., Maria Spiering wrote: > > Not yet working as expected, because Bob (non-host & write access) cannot select one or more projects and then select "Add to Saros Session". > > > > Furthermore definition "participantsHasWriteAccess" in the plugin.xml should be renamed since this is not correct English (singular/ plural form). Is the goal of this patch still valid? As far as i've understood your summary of Julia+Prechelts discussion about what users should be able to do and what not in our last meeting, non-host inviting should be fixed to work, rather than being disabled overall, right? @All Is there a non-formal specification of what functionality Saros should provide and what not? If not, shouldn't we be writing that thing as soon as possible and check if all features work as originally intended? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/243/#review755 ----------------------------------------------------------- On Jan. 24, 2012, 1:48 p.m., Alexander Waldmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/243/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2012, 1:48 p.m.) > > > Review request for Saros. > > > Summary > ------- > > See Bug http://sourceforge.net/tracker/?func=detail&aid=3476010&group_id=167540&atid=843359 > Non-host inviting doesn't work - ID: 3476010 > > Changed the plugin.xml to prevent non-host-users to invite buddies to the session since this should not be possible. > Also changed that readonly users cannot modify the session by adding projects to it, since they could not write in their own projects, and cannot prevent others from writing in their projects which is totaly confusing to the users. > > The host should always remain in control of the session. > Disabled the menu-items/context-menu-items like "add Buddy to session" and "add to session" if the user is not the host. > Disabled "share project" / "add project to session" if user does not have write access. > > > This addresses bugs 3472493 and 3476010. > http://sourceforge.net/support/tracker.php?aid=3472493 > http://sourceforge.net/support/tracker.php?aid=3476010 > > > Diffs > ----- > > trunk/dpp/de.fu_berlin.inf.dpp/plugin.xml 3705 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/243/diff > > > Testing > ------- > > manual testing done. > > > Thanks, > > Alexander > > |